[LTP] [PATCH v3 1/5] fanotify12: Drop incorrect hint

Cyril Hrubis
2020-11-19T10:06:43Z

Hi!
> hint "CONFIG_FANOTIFY_ACCESS_PERMISSIONS not configured in kernel?"
> is wrong here (fanotify12 does not use FAN_ACCESS_PERM).
>
> Suggested-by: Amir Goldstein <amir73il@gmail.com>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
> testcases/kernel/syscalls/fanotify/fanotify12.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/testcases/kernel/syscalls/fanotify/fanotify12.c b/testcases/kernel/syscalls/fanotify/fanotify12.c
> index fcb7ec0d3..7f23fc9dc 100644
> --- a/testcases/kernel/syscalls/fanotify/fanotify12.c
> +++ b/testcases/kernel/syscalls/fanotify/fanotify12.c
> @@ -146,10 +146,6 @@ static int setup_mark(unsigned int n)
> "FAN_OPEN_EXEC not supported in "
> "kernel?");
> return -1;
> - } else if (errno == EINVAL) {
> - tst_brk(TCONF | TERRNO,
> - "CONFIG_FANOTIFY_ACCESS_PERMISSIONS "
> - "not configured in kernel?");
> }else {
> tst_brk(TBROK | TERRNO,
> "fanotify_mark(%d, FAN_MARK_ADD | %s, "

Looking at the source there is the same message just couple of lines
below this one, should we get rid of that one as well?

--
Cyril Hrubis
chrubis@suse.cz