From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/1] net/traceroute01: Check also -T flag
Date: Thu, 19 Nov 2020 20:56:18 +0100 [thread overview]
Message-ID: <20201119195618.GA3181@pevik> (raw)
In-Reply-To: <cf76949d-32a7-7b2d-4d5b-6117676ecea6@oracle.com>
Hi Alexey,
> On 19.11.2020 18:41, Petr Vorel wrote:
> > Hi Kory, Alexey,
> >> Hello Petr,
> >> Just find out you didn't merge your patch which makes the code cleaner. :)
> > Waiting for Alexey's review.
> > Also hesitate about tracepath6 symlink to traceroute being always installed
I meant here traceroute6 symlink to traceroute.
> > on all distros (hopefully yes).
> Hi Petr,
> From the subject it seems you are adding a new check for -T flag
> but it is actually for -I option?
Good catch, thanks!
> I think it's ok using symlink or -4/-6,
If nobody complains I'd keep symlink version as it can check
traceroute from iputils. -4/-6 is more portable. If anybody complains and we
revert it back, I'd also put back iputils related warning.
> it is also adding an extra
> check for ipv6 that $(tst_ipaddr rhost) is indeed ipv6.
Sorry, I didn't get this.
BTW ack this change?
Kind regards,
Petr
next prev parent reply other threads:[~2020-11-19 19:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-12 17:36 [LTP] [PATCH 1/1] net/traceroute01: Check also -T flag Petr Vorel
2020-11-19 14:23 ` =?unknown-8bit?q?K=C3=B6ry?= Maincent
2020-11-19 15:41 ` Petr Vorel
2020-11-19 17:48 ` Alexey Kodanev
2020-11-19 19:56 ` Petr Vorel [this message]
2020-11-20 5:59 ` Alexey Kodanev
2020-11-20 8:45 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201119195618.GA3181@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox