ltp.lists.linux.it archive mirror
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v4] syscalls/ptrace11: Add test for tracing init process
Date: Fri, 20 Nov 2020 11:16:22 +0100	[thread overview]
Message-ID: <20201120101622.GA4910@yuki.lan> (raw)
In-Reply-To: <1605842193-10828-1-git-send-email-xuyang2018.jy@cn.fujitsu.com>

Hi!
> +// SPDX-License-Identifier: GPL-2.0-or-later
> +/*
> + * Copyright (c) 2020 FUJITSU LIMITED. All rights reserved.
> + * Author: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
> + *
> + * Before kernel 2.6.26, we can't trace init(1) process and ptrace() will
> + * get EPERM error. This case just check whether we can trace init(1)
> + * process and doesn't trigger error.
> + */

I've reformatted this comment so that it's picked up by documentation
parser.

> +#include <errno.h>
> +#include <signal.h>
> +#include <sys/wait.h>
> +#include <pwd.h>
> +#include <config.h>
> +#include <stdlib.h>
> +#include "ptrace.h"
> +#include "tst_test.h"
> +
> +static void verify_ptrace(void)
> +{
> +	TEST(ptrace(PTRACE_ATTACH, 1, NULL, NULL));
> +	if (TST_RET == 0)
> +		tst_res(TPASS, "ptrace() traces init process successfully");
> +	else
> +		tst_res(TFAIL | TTERRNO,
> +			"ptrace() returns %ld, failed unexpectedly", TST_RET);
> +
> +	/*
> +	 * As ptrace(2) man-page said, when using PTRACE_ATTACH option, the
> +	 * tracee is sent a SIGSTOP, but will not necessarily have stopped
> +	 * by the completion of this call. Use waitpid(2) to wait for the
> +	 * tracee into stop. Otherwise it may get ESRCH error.
> +	 * As waitpid(2) man-pages said, status for traced children which have
> +	 * stopped is provided even if WUNTRACED option is not specified.
> +	 * So using 0 option is enough.
> +	 */

Simplified this comment.


And pushed, thanks.

-- 
Cyril Hrubis
chrubis@suse.cz

  reply	other threads:[~2020-11-20 10:16 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-02 11:43 [LTP] [PATCH 2/2] syscalls/ptrace02: Add another EPERM error test Yang Xu
2020-11-11 15:09 ` Cyril Hrubis
2020-11-12  6:31   ` Yang Xu
2020-11-12  6:48   ` [LTP] [PATCH v2 1/2] " Yang Xu
2020-11-12  6:48     ` [LTP] [PATCH v2 2/2] syscalls/ptrace11: Add test for tracing init process Yang Xu
2020-11-12 10:32       ` Cyril Hrubis
2020-11-12 12:05         ` Cyril Hrubis
2020-11-13  1:33           ` Yang Xu
2020-11-13  2:07           ` [LTP] [PATCH v3] " Yang Xu
2020-11-13 15:12             ` Cyril Hrubis
2020-11-16 10:51               ` Yang Xu
2020-11-19 15:31                 ` Cyril Hrubis
2020-11-20  2:30                   ` Yang Xu
2020-11-20  3:16                   ` [LTP] [PATCH v4] " Yang Xu
2020-11-20 10:16                     ` Cyril Hrubis [this message]
2020-11-12 10:27     ` [LTP] [PATCH v2 1/2] syscalls/ptrace02: Add another EPERM error test Cyril Hrubis
2020-11-12 10:31       ` Cyril Hrubis
2020-11-13  1:29         ` Yang Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201120101622.GA4910@yuki.lan \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).