From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v4 3/6] fanotify: Check for FAN_REPORT_FID support on fs
Date: Fri, 27 Nov 2020 15:26:49 +0100 [thread overview]
Message-ID: <20201127142649.GA20397@pevik> (raw)
In-Reply-To: <CAOQ4uxh8yb+GRc2cN=MNcgBu8KZO=NPzmO9tSMkgRAvbUCXjZg@mail.gmail.com>
Hi Amir,
> Just a minor nit below.
> you may add:
> Reviewed-by: Amir Goldstein <amir73il@gmail.com>
Sure. Thanks for your review!
> As far as I am concerned, you do not need to re-post for the nits
> if Cyril is going to fix my nit on merge (or even if he doesn't)
Sure, I also hope that nothing controversial appear after 4 reviews.
...
> > There might be even more cleanup: not sure if nofid_fd in fanotify13.c
> > is required. According to the description is probably required:
> You're right, It is required.
Thanks for confirmation!
...
> > --- a/testcases/kernel/syscalls/fanotify/fanotify.h
...
> > +static inline int fanotify_fan_report_fid_supported_on_fs(const char *fname)
> > +{
> > + int fd;
> > + int rval = 0;
> > +
> > + fd = SAFE_FANOTIFY_INIT(FAN_CLASS_NOTIF | FAN_REPORT_FID, O_RDONLY);
> > +
> > + if (fanotify_mark(fd, FAN_MARK_ADD | FAN_MARK_FILESYSTEM,
> > + FAN_ACCESS | FAN_MODIFY | FAN_CLOSE | FAN_OPEN,
> > + AT_FDCWD, fname) < 0) {
> All those flags are not really needed for the test.
> This minimal arg list would have been enough:
> fanotify_mark(fd, FAN_MARK_ADD, FAN_ACCESS, AT_FDCWD, fname)
Ack, thanks!
> Thanks,
> Amir.
Kind regards,
Petr
next prev parent reply other threads:[~2020-11-27 14:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-26 21:41 [LTP] [PATCH v4 0/6] Introduce SAFE_FANOTIFY_MARK() macro + cleanup Petr Vorel
2020-11-26 21:41 ` [LTP] [PATCH v4 1/6] fanotify12: Drop incorrect hint Petr Vorel
2020-11-26 21:41 ` [LTP] [PATCH v4 2/6] fanotify: Handle supported features checks in setup() Petr Vorel
2020-11-27 13:20 ` Amir Goldstein
2020-11-26 21:41 ` [LTP] [PATCH v4 3/6] fanotify: Check for FAN_REPORT_FID support on fs Petr Vorel
2020-11-27 13:47 ` Amir Goldstein
2020-11-27 14:26 ` Petr Vorel [this message]
2020-11-26 21:41 ` [LTP] [PATCH v4 4/6] fanotify: Introduce SAFE_FANOTIFY_MARK() macro Petr Vorel
2020-11-27 15:17 ` Amir Goldstein
2020-11-26 21:41 ` [LTP] [PATCH v4 5/6] fanotify: Check FAN_REPORT_{FID, NAME} support Petr Vorel
2020-11-27 14:22 ` Amir Goldstein
2020-11-26 21:41 ` [LTP] [PATCH v4 6/6] fanotify: Add a pedantic check for return value Petr Vorel
2020-11-26 21:47 ` [LTP] [PATCH v4 0/6] Introduce SAFE_FANOTIFY_MARK() macro + cleanup Petr Vorel
2020-11-27 15:36 ` Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201127142649.GA20397@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox