public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Kory Maincent <kory.maincent@bootlin.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2] net/ip_tests: Return TCONF if driver dummy not present
Date: Tue,  1 Dec 2020 14:43:56 +0100	[thread overview]
Message-ID: <20201201134356.28635-1-kory.maincent@bootlin.com> (raw)

Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
---

Changes since v1:
 - Use TST_NEEDS_DRIVERS
 - Test ip4_addr before clean to avoid empty grep

 testcases/network/iproute/ip_tests.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/testcases/network/iproute/ip_tests.sh b/testcases/network/iproute/ip_tests.sh
index 41c515696..13722afb9 100755
--- a/testcases/network/iproute/ip_tests.sh
+++ b/testcases/network/iproute/ip_tests.sh
@@ -13,6 +13,7 @@ TST_CLEANUP="cleanup"
 TST_NEEDS_TMPDIR=1
 TST_NEEDS_ROOT=1
 TST_NEEDS_CMDS="cat awk diff"
+TST_NEEDS_DRIVERS="dummy"
 
 . tst_net.sh
 
@@ -51,7 +52,7 @@ cleanup()
 	[ "$rm_dummy" ] && modprobe -r dummy
 
 	# test #5
-	ip route show | grep $ip4_addr && ip route del $ip4_addr
+	[ "$ip4_addr" ] && ip route show | grep $ip4_addr && ip route del $ip4_addr
 }
 
 test1()
-- 
2.17.1


             reply	other threads:[~2020-12-01 13:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-01 13:43 Kory Maincent [this message]
2020-12-01 18:04 ` [LTP] [PATCH v2] net/ip_tests: Return TCONF if driver dummy not present Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201201134356.28635-1-kory.maincent@bootlin.com \
    --to=kory.maincent@bootlin.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox