From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v3] overcommit_memory: Fix unstable subtest
Date: Thu, 3 Dec 2020 16:30:30 +0100 [thread overview]
Message-ID: <20201203153030.GE5809@yuki.lan> (raw)
In-Reply-To: <20201127071419.20370-1-lkml@jv-coder.de>
Hi!
> +static long get_total_batch_size_bytes(void)
> +{
> + struct sysinfo info;
> + long ncpus = tst_ncpus_conf();
> + long pagesize = getpagesize();
> + SAFE_SYSINFO(&info);
> +
> + /* see linux source mm/mm_init.c mm_compute_batch() (This is in pages) */
> + long batch_size = MAX(
> + ncpus * 2,
> + MAX(
> + 32,
> + MIN(
> + INT32_MAX,
> + (long)(info.totalram / pagesize) / ncpus / 256
> + )
> + )
> + );
> +
> + /* there are ncpu separate counters, that can all grow up to
> + * batch_size. So the maximum error for __vm_enough_memory is
> + * batch_size * ncpus. */
> + return batch_size * ncpus * pagesize;
> +}
This version looks better. However two (minor) comments for this
function still apply.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2020-12-03 15:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-27 7:14 [LTP] [PATCH v3] overcommit_memory: Fix unstable subtest Joerg Vehlow
2020-11-30 8:01 ` Richard Palethorpe
2020-11-30 8:30 ` Joerg Vehlow
2020-11-30 8:54 ` Richard Palethorpe
2020-12-03 15:30 ` Cyril Hrubis [this message]
2020-12-04 5:35 ` Joerg Vehlow
2020-12-11 14:29 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201203153030.GE5809@yuki.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox