From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] ltp-pan: Use long long int to print time_t
Date: Mon, 21 Dec 2020 22:25:01 +0100 [thread overview]
Message-ID: <20201221212501.GB4453@pevik> (raw)
In-Reply-To: <20201221061415.2540216-1-raj.khem@gmail.com>
Hi Khem,
> Some newer 32bit architectures ( e.g. riscv32 ) uses 64bit time_t so
> using %ld is not sufficient to print time_t, this also fixes a crash in
> ltp-pan on riscv32
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
Reviewed-by: Petr Vorel <pvorel@suse.cz>
LGTM, thank you!
Kind regards,
Petr
> ---
> pan/ltp-pan.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> diff --git a/pan/ltp-pan.c b/pan/ltp-pan.c
> index 8b9fbe5594..54b7cb8f26 100644
> --- a/pan/ltp-pan.c
> +++ b/pan/ltp-pan.c
> @@ -1389,8 +1389,8 @@ static void write_test_start(struct tag_pgrp *running, int no_kmsg)
> if (!strcmp(reporttype, "rts")) {
> printf
> - ("%s\ntag=%s stime=%ld\ncmdline=\"%s\"\ncontacts=\"%s\"\nanalysis=%s\n%s\n",
> - "<<<test_start>>>", running->cmd->name, running->mystime,
> + ("%s\ntag=%s stime=%lld\ncmdline=\"%s\"\ncontacts=\"%s\"\nanalysis=%s\n%s\n",
> + "<<<test_start>>>", running->cmd->name, (long long)running->mystime,
> running->cmd->cmdline, "", "exit", "<<<test_output>>>");
> }
> fflush(stdout);
next prev parent reply other threads:[~2020-12-21 21:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-21 6:14 [LTP] [PATCH] ltp-pan: Use long long int to print time_t Khem Raj
2020-12-21 21:25 ` Petr Vorel [this message]
2020-12-22 17:05 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201221212501.GB4453@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox