From: Li Wang <liwang@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v3 3/4] lib: ignore SIGINT in _tst_kill_test
Date: Sat, 8 May 2021 13:51:08 +0800 [thread overview]
Message-ID: <20210508055109.16914-4-liwang@redhat.com> (raw)
We have to guarantee _tst_kill_test alive for a while to check if
the target test eixst or not, so ignore SIGINT in _tst_kill_test
is necessary, otherwise it will be stopped by the SIGINT sending
by itself.
The timeout03.sh verify this mechanism proccess well in output:
timeout03 1 TBROK: Test timeouted, sending SIGINT! If you are running on slow machine, try exporting LTP_TIMEOUT_MUL > 1
timeout03 1 TBROK: test interrupted or timed out
timeout03 1 TPASS: test run cleanup after timeout
timeout03 1 TINFO: Test is still running, waiting 10s
timeout03 1 TINFO: Test is still running, waiting 9s
timeout03 1 TINFO: Test is still running, waiting 8s
timeout03 1 TINFO: Test is still running, waiting 7s
timeout03 1 TINFO: Test is still running, waiting 6s
timeout03 1 TINFO: Test is still running, waiting 5s
timeout03 1 TINFO: Test is still running, waiting 4s
timeout03 1 TINFO: Test is still running, waiting 3s
timeout03 1 TINFO: Test is still running, waiting 2s
timeout03 1 TINFO: Test is still running, waiting 1s
timeout03 1 TBROK: Test still running, sending SIGKILL
Killed
(This one based on Joerg's improvement work, better apply this after the two patches)
Fixes: 25ad54dbaea6("tst_test.sh: Run cleanup also after test timeout")
Signed-off-by: Li Wang <liwang@redhat.com>
Cc: Joerg Vehlow <lkml@jv-coder.de>
Acked-by: Petr Vorel <pvorel@suse.cz>
---
testcases/lib/tst_test.sh | 1 +
1 file changed, 1 insertion(+)
diff --git a/testcases/lib/tst_test.sh b/testcases/lib/tst_test.sh
index ed2699175..b6ca0cb26 100644
--- a/testcases/lib/tst_test.sh
+++ b/testcases/lib/tst_test.sh
@@ -439,6 +439,7 @@ _tst_kill_test()
{
local i=10
+ trap '' INT
tst_res TBROK "Test timeouted, sending SIGINT! If you are running on slow machine, try exporting LTP_TIMEOUT_MUL > 1"
kill -INT -$pid
tst_sleep 100ms
--
2.30.2
next reply other threads:[~2021-05-08 5:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-08 5:51 Li Wang [this message]
2021-05-10 11:47 ` [LTP] [PATCH v3 3/4] lib: ignore SIGINT in _tst_kill_test Cyril Hrubis
2021-05-11 5:54 ` Joerg Vehlow
2021-05-12 9:49 ` Li Wang
2021-05-12 10:34 ` Joerg Vehlow
2021-05-12 14:20 ` Petr Vorel
2021-05-13 5:08 ` Li Wang
2021-05-14 7:53 ` Petr Vorel
2021-05-14 9:10 ` Li Wang
2021-05-14 15:10 ` Petr Vorel
2021-05-18 4:57 ` Joerg Vehlow
2021-05-18 7:27 ` Li Wang
2021-05-18 8:46 ` Petr Vorel
2021-05-18 9:45 ` Joerg Vehlow
2021-05-18 12:01 ` Li Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210508055109.16914-4-liwang@redhat.com \
--to=liwang@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox