* [LTP] [PATCH v6, 2/4] doc: change the default behavior of tst_umount
@ 2021-08-04 1:53 Leo Liang
2021-08-23 13:54 ` Petr Vorel
0 siblings, 1 reply; 2+ messages in thread
From: Leo Liang @ 2021-08-04 1:53 UTC (permalink / raw)
To: ltp
Modify tst_umount to umount TST_MNTPOINT by default.
Signed-off-by: Leo Yu-Chi Liang <ycliang@andestech.com>
---
doc/shell-test-api.txt | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/doc/shell-test-api.txt b/doc/shell-test-api.txt
index bf297ab07..ecdbe9e6a 100644
--- a/doc/shell-test-api.txt
+++ b/doc/shell-test-api.txt
@@ -515,11 +515,11 @@ The 'tst_mount' mounts '$TST_DEVICE' of '$TST_FS_TYPE' (optional) to
'$TST_MNT_PARAMS'. The '$TST_MNTPOINT' directory is created if it didn't
exist prior to the function call.
-If the path passed (optional, defaults to '$TST_DEVICE') to the 'tst_umount' is
+If the path passed (optional, defaults to '$TST_MNTPOINT') to the 'tst_umount' is
not mounted (present in '/proc/mounts') it's noop.
-Otherwise it retries to umount the filesystem a few times on a failure, which
-is a workaround since there are a daemons dumb enough to probe all newly
-mounted filesystems, which prevents them from umounting shortly after they
+Otherwise it retries to umount the filesystem a few times on failure.
+This is a workaround since there are daemons dumb enough to probe all newly
+mounted filesystems, and prevents them from being umounted shortly after they
were mounted.
ROD and ROD_SILENT
--
2.17.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [LTP] [PATCH v6, 2/4] doc: change the default behavior of tst_umount
2021-08-04 1:53 [LTP] [PATCH v6, 2/4] doc: change the default behavior of tst_umount Leo Liang
@ 2021-08-23 13:54 ` Petr Vorel
0 siblings, 0 replies; 2+ messages in thread
From: Petr Vorel @ 2021-08-23 13:54 UTC (permalink / raw)
To: ltp
> Modify tst_umount to umount TST_MNTPOINT by default.
nit: I'd add "in previous commit"
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Kind regards,
Petr
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-08-23 13:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-08-04 1:53 [LTP] [PATCH v6, 2/4] doc: change the default behavior of tst_umount Leo Liang
2021-08-23 13:54 ` Petr Vorel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox