Re: [LTP] [RFC PATCH v2 1/3] tst_netdevice.c: Drop redundant include

Cyril Hrubis
2021-10-06T13:51:01Z

Hi!
> <linux/rtnetlink.h> is already included in lapi/rtnetlink.h.
^
which includes <linux/netlink.h>

I suppose that you have tested this in CI and that it works fine. If
that is so:

Acked-by: Cyril Hrubis <chrubis@suse.cz>

> Signed-off-by: Petr Vorel <petr.vorel@gmail.com>
> ---
> lib/tst_netdevice.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/lib/tst_netdevice.c b/lib/tst_netdevice.c
> index ba9a55b70..4a0442932 100644
> --- a/lib/tst_netdevice.c
> +++ b/lib/tst_netdevice.c
> @@ -4,7 +4,6 @@
> */
>
> #include <asm/types.h>
> -#include <linux/netlink.h>
> #include <linux/veth.h>
> #include <sys/socket.h>
> #include <net/if.h>
> --
> 2.33.0
>

--
Cyril Hrubis
chrubis@suse.cz