From: Joerg Vehlow <lkml@jv-coder.de>
To: ltp@lists.linux.it
Cc: Joerg Vehlow <joerg.vehlow@aox-tech.de>
Subject: [LTP] [PATCH 04/12] posix/conformance/interfaces: Fix unsued-variable for testfrmw
Date: Fri, 19 Nov 2021 08:45:54 +0100 [thread overview]
Message-ID: <20211119074602.857595-5-lkml@jv-coder.de> (raw)
In-Reply-To: <20211119074602.857595-1-lkml@jv-coder.de>
From: Joerg Vehlow <joerg.vehlow@aox-tech.de>
Thre is a global variable sc in testfrmw/threads_scenarii, that is used,
if the integrated main function (STD_MAIN) is used. However some tests
did not use this integrated main, but still used the variable. To be able to
get rid of all warnings, the variable is duplicated into these tests and only
defined by threads_scenarii, if STD_MAIN is defined
Signed-off-by: Joerg Vehlow <joerg.vehlow@aox-tech.de>
---
.../conformance/interfaces/pthread_create/14-1.c | 2 ++
.../conformance/interfaces/pthread_create/3-2.c | 2 ++
.../conformance/interfaces/pthread_detach/1-2.c | 2 ++
.../conformance/interfaces/pthread_detach/2-2.c | 1 +
.../conformance/interfaces/pthread_detach/4-3.c | 1 +
.../conformance/interfaces/pthread_exit/6-1.c | 1 +
.../conformance/interfaces/pthread_join/1-2.c | 2 ++
.../conformance/interfaces/pthread_join/4-1.c | 1 +
.../conformance/interfaces/pthread_join/6-3.c | 1 +
.../conformance/interfaces/testfrmw/threads_scenarii.c | 4 ++--
10 files changed, 15 insertions(+), 2 deletions(-)
diff --git a/testcases/open_posix_testsuite/conformance/interfaces/pthread_create/14-1.c b/testcases/open_posix_testsuite/conformance/interfaces/pthread_create/14-1.c
index c21860ba8..84d229afc 100644
--- a/testcases/open_posix_testsuite/conformance/interfaces/pthread_create/14-1.c
+++ b/testcases/open_posix_testsuite/conformance/interfaces/pthread_create/14-1.c
@@ -47,6 +47,8 @@ static volatile long sleep_time;
/* number of pthread_create scenarios tested */
static unsigned long count_ope;
+static unsigned int sc;
+
static unsigned long long current_time_usec(void)
{
struct timeval now;
diff --git a/testcases/open_posix_testsuite/conformance/interfaces/pthread_create/3-2.c b/testcases/open_posix_testsuite/conformance/interfaces/pthread_create/3-2.c
index 433ccd8fe..3197bdf67 100644
--- a/testcases/open_posix_testsuite/conformance/interfaces/pthread_create/3-2.c
+++ b/testcases/open_posix_testsuite/conformance/interfaces/pthread_create/3-2.c
@@ -104,6 +104,8 @@
static sem_t semsync[2]; /* These semaphores will only be used in child process! */
+static unsigned int sc;
+
/* The overflow function is used to test the stack overflow */
static void *overflow(void *arg)
{
diff --git a/testcases/open_posix_testsuite/conformance/interfaces/pthread_detach/1-2.c b/testcases/open_posix_testsuite/conformance/interfaces/pthread_detach/1-2.c
index a6eb391ef..28a7e9ea9 100644
--- a/testcases/open_posix_testsuite/conformance/interfaces/pthread_detach/1-2.c
+++ b/testcases/open_posix_testsuite/conformance/interfaces/pthread_detach/1-2.c
@@ -91,6 +91,8 @@
/*********************************** Real Test *****************************************/
/********************************************************************************************/
+static unsigned int sc;
+
static void *threaded(void *arg)
{
int ret = 0;
diff --git a/testcases/open_posix_testsuite/conformance/interfaces/pthread_detach/2-2.c b/testcases/open_posix_testsuite/conformance/interfaces/pthread_detach/2-2.c
index 8a406fe44..a2c5cc657 100644
--- a/testcases/open_posix_testsuite/conformance/interfaces/pthread_detach/2-2.c
+++ b/testcases/open_posix_testsuite/conformance/interfaces/pthread_detach/2-2.c
@@ -93,6 +93,7 @@
/********************************************************************************************/
static sem_t sem_sync;
+static unsigned int sc;
static void *threaded(void *arg)
{
diff --git a/testcases/open_posix_testsuite/conformance/interfaces/pthread_detach/4-3.c b/testcases/open_posix_testsuite/conformance/interfaces/pthread_detach/4-3.c
index fc3a50bef..126f5aa82 100644
--- a/testcases/open_posix_testsuite/conformance/interfaces/pthread_detach/4-3.c
+++ b/testcases/open_posix_testsuite/conformance/interfaces/pthread_detach/4-3.c
@@ -61,6 +61,7 @@ static sem_t semsig1;
static unsigned long count_sig;
static long sleep_time;
static sigset_t usersigs;
+static unsigned int sc;
struct thestruct {
int sig;
diff --git a/testcases/open_posix_testsuite/conformance/interfaces/pthread_exit/6-1.c b/testcases/open_posix_testsuite/conformance/interfaces/pthread_exit/6-1.c
index b21e43d7b..639e508c2 100644
--- a/testcases/open_posix_testsuite/conformance/interfaces/pthread_exit/6-1.c
+++ b/testcases/open_posix_testsuite/conformance/interfaces/pthread_exit/6-1.c
@@ -98,6 +98,7 @@
/* This will be used to control that atexit() has been called */
static int *ctl;
static long mf;
+static unsigned int sc;
static void clnp(void)
{
diff --git a/testcases/open_posix_testsuite/conformance/interfaces/pthread_join/1-2.c b/testcases/open_posix_testsuite/conformance/interfaces/pthread_join/1-2.c
index 34c410967..25e623fdb 100644
--- a/testcases/open_posix_testsuite/conformance/interfaces/pthread_join/1-2.c
+++ b/testcases/open_posix_testsuite/conformance/interfaces/pthread_join/1-2.c
@@ -48,6 +48,8 @@
#include "../testfrmw/threads_scenarii.c"
+static unsigned int sc;
+
static void *threaded(void *arg)
{
int ret = 0;
diff --git a/testcases/open_posix_testsuite/conformance/interfaces/pthread_join/4-1.c b/testcases/open_posix_testsuite/conformance/interfaces/pthread_join/4-1.c
index b7bc56eac..6b19992ba 100644
--- a/testcases/open_posix_testsuite/conformance/interfaces/pthread_join/4-1.c
+++ b/testcases/open_posix_testsuite/conformance/interfaces/pthread_join/4-1.c
@@ -46,6 +46,7 @@
#include "../testfrmw/threads_scenarii.c"
static pthread_mutex_t mtx = PTHREAD_MUTEX_INITIALIZER;
+static unsigned int sc;
/* 1st thread function */
static void *threaded(void *arg PTS_ATTRIBUTE_UNUSED)
diff --git a/testcases/open_posix_testsuite/conformance/interfaces/pthread_join/6-3.c b/testcases/open_posix_testsuite/conformance/interfaces/pthread_join/6-3.c
index 7325defc3..ecf0498fa 100644
--- a/testcases/open_posix_testsuite/conformance/interfaces/pthread_join/6-3.c
+++ b/testcases/open_posix_testsuite/conformance/interfaces/pthread_join/6-3.c
@@ -56,6 +56,7 @@ static unsigned long count_sig;
#endif
static sigset_t usersigs;
+static unsigned int sc;
struct thestruct {
int sig;
diff --git a/testcases/open_posix_testsuite/conformance/interfaces/testfrmw/threads_scenarii.c b/testcases/open_posix_testsuite/conformance/interfaces/testfrmw/threads_scenarii.c
index baf30a87c..645aff604 100644
--- a/testcases/open_posix_testsuite/conformance/interfaces/testfrmw/threads_scenarii.c
+++ b/testcases/open_posix_testsuite/conformance/interfaces/testfrmw/threads_scenarii.c
@@ -482,10 +482,10 @@ static void scenar_fini(void)
}
}
-static unsigned int sc;
-
#ifdef STD_MAIN
+static unsigned int sc;
+
static void *threaded(void *arg);
int main(void)
--
2.25.1
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2021-11-19 7:46 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-19 7:45 [LTP] [Patch 00/12] Fix or suppress compiler warnings in posix/conformance/interfaces Joerg Vehlow
2021-11-19 7:45 ` [LTP] [PATCH 01/12] posix/pthread_create/15-1: Supress warning Joerg Vehlow
2021-11-19 14:34 ` Cyril Hrubis
2021-11-19 7:45 ` [LTP] [PATCH 02/12] posix/mq_(timed)send/5-1: Fix error reporting Joerg Vehlow
2021-11-19 14:44 ` Cyril Hrubis
2021-11-22 6:45 ` Joerg Vehlow
2021-11-22 9:10 ` Cyril Hrubis
2021-11-19 7:45 ` [LTP] [PATCH 03/12] posix/pthread_create/*: Remove unused variable Joerg Vehlow
2021-11-19 14:51 ` Cyril Hrubis
2021-11-19 7:45 ` Joerg Vehlow [this message]
2021-11-19 15:07 ` [LTP] [PATCH 04/12] posix/conformance/interfaces: Fix unsued-variable for testfrmw Cyril Hrubis
2021-11-22 6:48 ` Joerg Vehlow
2021-11-19 7:45 ` [LTP] [PATCH 05/12] posix/conformance/interfaces: Fix all unused variable warnings Joerg Vehlow
2021-11-19 15:23 ` Cyril Hrubis
2021-11-22 6:41 ` Joerg Vehlow
2021-11-22 9:43 ` Cyril Hrubis
2021-11-19 7:45 ` [LTP] [PATCH 06/12] posix/conformance/interfaces: Fix all unused function warnings Joerg Vehlow
2021-11-19 15:27 ` Cyril Hrubis
2021-11-19 7:45 ` [LTP] [PATCH 07/12] posix/pthread_key_create/2-1: Remove invalid part of test Joerg Vehlow
2021-11-19 15:32 ` Cyril Hrubis
2021-11-19 7:45 ` [LTP] [PATCH 08/12] posix/asctime: Fix potentioal buffer overflow Joerg Vehlow
2021-11-19 15:33 ` Cyril Hrubis
2021-11-19 7:45 ` [LTP] [PATCH 09/12] posix/conformance/interfaces/pthread_*_destroy: Suppress nonnull warning Joerg Vehlow
2021-11-19 15:35 ` Cyril Hrubis
2021-11-19 7:46 ` [LTP] [PATCH 10/12] posix/conformance/interfaces: Fix all sign-compare warnings Joerg Vehlow
2021-11-19 15:37 ` Cyril Hrubis
2021-11-19 7:46 ` [LTP] [PATCH 11/12] posix/conformance/interface/mmap/5-1: Remove invalid static Joerg Vehlow
2021-11-19 15:38 ` Cyril Hrubis
2021-11-19 7:46 ` [LTP] [PATCH 12/12] posix/interface/conformance: Fix/supress all unused-result warnings Joerg Vehlow
2021-11-19 15:43 ` Cyril Hrubis
2021-11-22 6:42 ` Joerg Vehlow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211119074602.857595-5-lkml@jv-coder.de \
--to=lkml@jv-coder.de \
--cc=joerg.vehlow@aox-tech.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox