From: Kushal Chand <kushalkataria5@gmail.com>
To: ltp@lists.linux.it
Cc: Kushal Chand <kushalkataria5@gmail.com>
Subject: [LTP] [PATCH v3] tst_taint: print readable error message instead of numerical codes
Date: Thu, 20 Jan 2022 22:04:07 +0530 [thread overview]
Message-ID: <20220120163407.30744-1-kushalkataria5@gmail.com> (raw)
This patch stores the possible kernel tainted messages in taint_strings
and corresponding error is printed.
Fixes: #776
---
lib/tst_taint.c | 27 ++++++++++++++++++++++++++-
1 file changed, 26 insertions(+), 1 deletion(-)
diff --git a/lib/tst_taint.c b/lib/tst_taint.c
index 49146aacb..e224984f5 100644
--- a/lib/tst_taint.c
+++ b/lib/tst_taint.c
@@ -8,6 +8,27 @@
static unsigned int taint_mask = -1;
+static const char * const taint_strings[] = {
+ "G (Propriety module loaded)",
+ "F (Module force loaded)",
+ "S (Running on out of spec system)",
+ "R (Module force unloaded)",
+ "M (Machine check exception)",
+ "B (Bad page reference)",
+ "U (User request)",
+ "D (OOPS/BUG)",
+ "A (ACPI table overridden)",
+ "W (Warning)",
+ "C (Staging driver loaded)",
+ "I (Workaround BIOS/FW bug)",
+ "O (Out of tree module loaded)",
+ "E (Unsigned module loaded)",
+ "L (Soft lock up occured)",
+ "K (Live patched)",
+ "X (Auxilary)",
+ "T (Built with struct randomization)",
+};
+
static unsigned int tst_taint_read(void)
{
unsigned int val;
@@ -74,6 +95,7 @@ static int tst_taint_check_kver(unsigned int mask)
void tst_taint_init(unsigned int mask)
{
unsigned int taint = -1;
+ long unsigned int i;
if (mask == 0)
tst_brk(TBROK, "mask is not allowed to be 0");
@@ -90,7 +112,10 @@ void tst_taint_init(unsigned int mask)
}
if ((taint & taint_mask) != 0)
- tst_brk(TBROK, "Kernel is already tainted: %u", taint);
+ for (i = 0; i < ARRAY_SIZE(taint_strings); i++)
+ if (taint & (1 << i))
+ tst_brk(TBROK, "Kernel is already tainted: %s",
+ taint_strings[i]);
}
--
2.25.1
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next reply other threads:[~2022-01-20 16:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-20 16:34 Kushal Chand [this message]
2022-01-20 20:14 ` [LTP] [PATCH v3] tst_taint: print readable error message instead of numerical codes Petr Vorel
2022-01-21 6:19 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220120163407.30744-1-kushalkataria5@gmail.com \
--to=kushalkataria5@gmail.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox