From: Martin Doucha <mdoucha@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] Fix setsockopt(PACKET_RX_RING) usage on PPC64
Date: Thu, 24 Feb 2022 16:34:02 +0100 [thread overview]
Message-ID: <20220224153402.1778-1-mdoucha@suse.cz> (raw)
struct tpacket_req3.tp_block_size value must be a multiple of page size.
Replace constants with values calculated from actual page size to fix
setsockopt() tests on PPC64 which has 64KB pages instead of 4KB.
Signed-off-by: Martin Doucha <mdoucha@suse.cz>
---
testcases/kernel/syscalls/setsockopt/setsockopt06.c | 6 ++++--
testcases/kernel/syscalls/setsockopt/setsockopt07.c | 6 ++++--
testcases/kernel/syscalls/setsockopt/setsockopt09.c | 4 +++-
3 files changed, 11 insertions(+), 5 deletions(-)
diff --git a/testcases/kernel/syscalls/setsockopt/setsockopt06.c b/testcases/kernel/syscalls/setsockopt/setsockopt06.c
index 12a80dee4..644e61f3f 100644
--- a/testcases/kernel/syscalls/setsockopt/setsockopt06.c
+++ b/testcases/kernel/syscalls/setsockopt/setsockopt06.c
@@ -28,6 +28,7 @@
#include "lapi/if_ether.h"
static int sock = -1;
+static unsigned int pagesize;
static struct tst_fzsync_pair fzsync_pair;
static void setup(void)
@@ -35,6 +36,7 @@ static void setup(void)
int real_uid = getuid();
int real_gid = getgid();
+ pagesize = SAFE_SYSCONF(_SC_PAGESIZE);
SAFE_TRY_FILE_PRINTF("/proc/sys/user/max_user_namespaces", "%d", 10);
SAFE_UNSHARE(CLONE_NEWUSER);
@@ -52,9 +54,9 @@ static void *thread_run(void *arg)
{
int ret;
struct tpacket_req3 req = {
- .tp_block_size = 4096,
+ .tp_block_size = pagesize,
.tp_block_nr = 1,
- .tp_frame_size = 4096,
+ .tp_frame_size = pagesize,
.tp_frame_nr = 1,
.tp_retire_blk_tov = 100
};
diff --git a/testcases/kernel/syscalls/setsockopt/setsockopt07.c b/testcases/kernel/syscalls/setsockopt/setsockopt07.c
index d2c568e3e..d22f9918b 100644
--- a/testcases/kernel/syscalls/setsockopt/setsockopt07.c
+++ b/testcases/kernel/syscalls/setsockopt/setsockopt07.c
@@ -31,6 +31,7 @@
#include "lapi/if_ether.h"
static int sock = -1;
+static unsigned int pagesize;
static struct tst_fzsync_pair fzsync_pair;
static void setup(void)
@@ -38,6 +39,7 @@ static void setup(void)
int real_uid = getuid();
int real_gid = getgid();
+ pagesize = SAFE_SYSCONF(_SC_PAGESIZE);
SAFE_TRY_FILE_PRINTF("/proc/sys/user/max_user_namespaces", "%d", 10);
SAFE_UNSHARE(CLONE_NEWUSER);
@@ -73,9 +75,9 @@ static void run(void)
unsigned int val, version = TPACKET_V3;
socklen_t vsize = sizeof(val);
struct tpacket_req3 req = {
- .tp_block_size = 4096,
+ .tp_block_size = pagesize,
.tp_block_nr = 1,
- .tp_frame_size = 4096,
+ .tp_frame_size = pagesize,
.tp_frame_nr = 1,
.tp_retire_blk_tov = 100
};
diff --git a/testcases/kernel/syscalls/setsockopt/setsockopt09.c b/testcases/kernel/syscalls/setsockopt/setsockopt09.c
index baaefda15..2fc66ebbc 100644
--- a/testcases/kernel/syscalls/setsockopt/setsockopt09.c
+++ b/testcases/kernel/syscalls/setsockopt/setsockopt09.c
@@ -31,12 +31,14 @@
#include "lapi/if_packet.h"
static int sock = -1;
+static unsigned int pagesize;
static void setup(void)
{
int real_uid = getuid();
int real_gid = getgid();
+ pagesize = SAFE_SYSCONF(_SC_PAGESIZE);
SAFE_TRY_FILE_PRINTF("/proc/sys/user/max_user_namespaces", "%d", 10);
SAFE_UNSHARE(CLONE_NEWUSER);
@@ -50,7 +52,7 @@ static void run(void)
{
unsigned int version = TPACKET_V3;
struct tpacket_req3 req = {
- .tp_block_size = 16384,
+ .tp_block_size = 4 * pagesize,
.tp_block_nr = 256,
.tp_frame_size = TPACKET_ALIGNMENT << 7,
.tp_retire_blk_tov = 64,
--
2.34.1
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next reply other threads:[~2022-02-24 15:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-24 15:34 Martin Doucha [this message]
2022-02-25 10:56 ` [LTP] [PATCH] Fix setsockopt(PACKET_RX_RING) usage on PPC64 Petr Vorel
2022-02-25 11:21 ` Cyril Hrubis
2022-02-25 11:41 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220224153402.1778-1-mdoucha@suse.cz \
--to=mdoucha@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox