From: Edward Liaw via ltp <ltp@lists.linux.it>
To: ltp@lists.linux.it
Cc: kernel-team@android.com
Subject: [LTP] [PATCH v2] syscalls/signal06: loop being clobbered by syscall on clang
Date: Fri, 19 Aug 2022 21:31:48 +0000 [thread overview]
Message-ID: <20220819213148.1995580-1-edliaw@google.com> (raw)
Indicate to the compiler that the syscall will modify registers rcx
and r11 to prevent loop from getting clobbered.
Signed-off-by: Edward Liaw <edliaw@google.com>
---
When I combined the asm instruction into one line, it threw an error
that the "Asm-specifier for input or output variable conflicts with asm
clobber list" for rax. I omitted it for now, but I'm not sure if that
is correct.
Also, is it ok to change the subject line like I did?
---
testcases/kernel/syscalls/signal/signal06.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/testcases/kernel/syscalls/signal/signal06.c b/testcases/kernel/syscalls/signal/signal06.c
index 64f886ee3..fba380610 100644
--- a/testcases/kernel/syscalls/signal/signal06.c
+++ b/testcases/kernel/syscalls/signal/signal06.c
@@ -72,8 +72,7 @@ void test(void)
while (D == VALUE && loop < LOOPS) {
/* sys_tkill(pid, SIGHUP); asm to avoid save/reload
* fp regs around c call */
- asm ("" : : "a"(__NR_tkill), "D"(pid), "S"(SIGHUP));
- asm ("syscall" : : : "ax");
+ asm volatile ("syscall" : : "a"(__NR_tkill), "D"(pid), "S"(SIGHUP) : "rcx", "r11");
loop++;
}
--
2.37.2.609.g9ff673ca1a-goog
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next reply other threads:[~2022-08-19 21:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-19 21:31 Edward Liaw via ltp [this message]
2022-08-19 22:34 ` [LTP] [PATCH v2] syscalls/signal06: loop being clobbered by syscall on clang Viktor Martensson via ltp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220819213148.1995580-1-edliaw@google.com \
--to=ltp@lists.linux.it \
--cc=edliaw@google.com \
--cc=kernel-team@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox