From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 107FEC433FE for ; Sun, 16 Oct 2022 13:00:52 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 894F63CAFB7 for ; Sun, 16 Oct 2022 15:00:50 +0200 (CEST) Received: from in-3.smtp.seeweb.it (in-3.smtp.seeweb.it [IPv6:2001:4b78:1:20::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 9F6093CAFBE for ; Sun, 16 Oct 2022 14:59:05 +0200 (CEST) Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by in-3.smtp.seeweb.it (Postfix) with ESMTPS id 555361A00668 for ; Sun, 16 Oct 2022 14:59:02 +0200 (CEST) Received: from pps.filterd (m0098404.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 29G8psBm032489 for ; Sun, 16 Oct 2022 12:59:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding; s=pp1; bh=Bp+DuSpcmmhHWbcAjeUZep1BC650v3+UYzxndTjQMXY=; b=Mt4ylTW82deY2xh0CIOB/MC18UFpuMRJGdDw3IXa0R3amsmQE+mcJK+tMuT1EUFBGcLM TVoSlXlslpsseZY4pQzgycqrYgwydJneLzCemE0coeJFkFDWnczy/TgUefL2XjD7Prm5 kpuH/I+3HchQf5MxL9l9PNnKdisevYk1JIszMpUalRPsJbbAKxLr2S8fsaB6dWsKTmvt xWC1ByNLQ4A6sMuSFuqdtUaCMJDBofzFeyKIXouUgX4pVN2rFKIbUVGU0ztCGIF4JDgS KKzbzLSVEInEDSuRVLMxyLnZI897ur6uenP3AjdtK5sBbr6s8K1EW4X2kV0fxtTXWUAM bA== Received: from ppma03ams.nl.ibm.com (62.31.33a9.ip4.static.sl-reverse.com [169.51.49.98]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3k866aw3ng-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sun, 16 Oct 2022 12:59:00 +0000 Received: from pps.filterd (ppma03ams.nl.ibm.com [127.0.0.1]) by ppma03ams.nl.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 29GCpTk6011424 for ; Sun, 16 Oct 2022 12:58:58 GMT Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by ppma03ams.nl.ibm.com with ESMTP id 3k7mg91kr9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sun, 16 Oct 2022 12:58:58 +0000 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 29GCwt6g66912666 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 16 Oct 2022 12:58:55 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 469C011C04C; Sun, 16 Oct 2022 12:58:55 +0000 (GMT) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9355E11C04A; Sun, 16 Oct 2022 12:58:53 +0000 (GMT) Received: from tarunpc.ibmuc.com (unknown [9.43.63.52]) by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP; Sun, 16 Oct 2022 12:58:53 +0000 (GMT) From: Tarun Sahu To: ltp@lists.linux.it Date: Sun, 16 Oct 2022 18:27:11 +0530 Message-Id: <20221016125731.249078-10-tsahu@linux.ibm.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20221016125731.249078-1-tsahu@linux.ibm.com> References: <20221016125731.249078-1-tsahu@linux.ibm.com> MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: uTD5pGGvcikVt6hFP2C06O2hUhezkoEE X-Proofpoint-ORIG-GUID: uTD5pGGvcikVt6hFP2C06O2hUhezkoEE X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-10-16_08,2022-10-14_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 impostorscore=0 mlxscore=0 adultscore=0 mlxlogscore=999 lowpriorityscore=0 malwarescore=0 priorityscore=1501 suspectscore=0 clxscore=1015 spamscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000 definitions=main-2210160074 X-Virus-Scanned: clamav-milter 0.102.4 at in-3.smtp.seeweb.it X-Virus-Status: Clean Subject: [LTP] [PATCH 09/29] Hugetlb: Migrating libhugetlbfs fork-cow X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: aneesh.kumar@linux.ibm.com, sbhat@linux.ibm.com, vaibhav@linux.ibm.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Migrating the libhugetlbfs/testcases/fork-cow.c test Test Description: This checks copy-on-write semantics, specifically the semantics of a MAP_PRIVATE mapping across a fork(). Some versions of the powerpc kernel had a bug in huge_ptep_set_wrprotect() which would fail to flush the hash table after setting the write protect bit in the parent's page tables, thus allowing the parent to pollute the child's mapping. Signed-off-by: Tarun Sahu --- runtest/hugetlb | 2 + testcases/kernel/mem/.gitignore | 1 + .../kernel/mem/hugetlb/hugefork/Makefile | 10 + .../kernel/mem/hugetlb/hugefork/hugefork01.c | 220 ++++++++++++++++++ 4 files changed, 233 insertions(+) create mode 100644 testcases/kernel/mem/hugetlb/hugefork/Makefile create mode 100644 testcases/kernel/mem/hugetlb/hugefork/hugefork01.c diff --git a/runtest/hugetlb b/runtest/hugetlb index ec1fc2515..4c16e1e7c 100644 --- a/runtest/hugetlb +++ b/runtest/hugetlb @@ -1,6 +1,8 @@ hugefallocate01 hugefallocate01 hugefallocate02 hugefallocate02 +hugefork01 hugefork01 + hugemmap01 hugemmap01 hugemmap02 hugemmap02 hugemmap04 hugemmap04 diff --git a/testcases/kernel/mem/.gitignore b/testcases/kernel/mem/.gitignore index c0906f3d3..adea760c7 100644 --- a/testcases/kernel/mem/.gitignore +++ b/testcases/kernel/mem/.gitignore @@ -1,6 +1,7 @@ /cpuset/cpuset01 /hugetlb/hugefallocate/hugefallocate01 /hugetlb/hugefallocate/hugefallocate02 +/hugetlb/hugefork/hugefork01 /hugetlb/hugemmap/hugemmap01 /hugetlb/hugemmap/hugemmap02 /hugetlb/hugemmap/hugemmap04 diff --git a/testcases/kernel/mem/hugetlb/hugefork/Makefile b/testcases/kernel/mem/hugetlb/hugefork/Makefile new file mode 100644 index 000000000..77ebb0aef --- /dev/null +++ b/testcases/kernel/mem/hugetlb/hugefork/Makefile @@ -0,0 +1,10 @@ +# SPDX-License-Identifier: GPL-2.0-or-later +# Copyright (C) 2009, Cisco Systems Inc. +# Ngie Cooper, July 2009 + +top_srcdir ?= ../../../../.. + +include $(top_srcdir)/include/mk/testcases.mk +include $(abs_srcdir)/../Makefile.inc +include $(top_srcdir)/include/mk/generic_leaf_target.mk + diff --git a/testcases/kernel/mem/hugetlb/hugefork/hugefork01.c b/testcases/kernel/mem/hugetlb/hugefork/hugefork01.c new file mode 100644 index 000000000..096ff0c4d --- /dev/null +++ b/testcases/kernel/mem/hugetlb/hugefork/hugefork01.c @@ -0,0 +1,220 @@ +// SPDX-License-Identifier: LGPL-2.1-or-later +/* + * Copyright (C) 2008 David Gibson, IBM Corporation. + * + * Test Name: fork COW + * + * Test Description: This checks copy-on-write semantics, specifically the + * semantics of a MAP_PRIVATE mapping across a fork(). Some versions of the + * powerpc kernel had a bug in huge_ptep_set_wrprotect() which would fail to + * flush the hash table after setting the write protect bit in the parent's + * page tables, thus allowing the parent to pollute the child's mapping. + * + * HISTORY + * Written by David Gibson + * + */ + +#define _GNU_SOURCE + + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include "hugetlb.h" + +#define RANDOM_CONSTANT 0x1234ABCD +#define OTHER_CONSTANT 0xfeef5678 + +static int fd = -1; +static char hfile[MAXPATHLEN]; +static long hpage_size; +static char *verbose; + +/* + * The parent uses this to check if the child terminated badly. + */ +static void sigchld_handler(int signum, siginfo_t *si, void *uc) +{ + (void)signum; + (void)uc; + if (WEXITSTATUS(si->si_status) != 0) { + tst_res(TFAIL, "Child failed: %d", WEXITSTATUS(si->si_status)); + goto fail; + } + if (WIFSIGNALED(si->si_status)) { + tst_res(TFAIL, "Child recived signal %s", + strsignal(WTERMSIG(si->si_status))); + goto fail; + } + return; +fail: + tst_brk(TBROK, "Once failed, No point in continuing the test"); +} + +static void run_test(void) +{ + int status; + void *syncarea; + volatile unsigned int *p; + volatile unsigned int *trigger, *child_readback; + int parent_readback; + pid_t pid; + struct sigaction sa = { + .sa_sigaction = sigchld_handler, + .sa_flags = SA_SIGINFO, + }; + + /* Get a shared normal page for synchronization */ + if (verbose) + tst_res(TINFO, "Mapping synchronization area.."); + syncarea = SAFE_MMAP(NULL, getpagesize(), PROT_READ|PROT_WRITE, + MAP_SHARED|MAP_ANONYMOUS, -1, 0); + if (verbose) + tst_res(TINFO, "done"); + + trigger = syncarea; + *trigger = 0; + + child_readback = trigger + 1; + *child_readback = 0; + + fd = SAFE_OPEN(hfile, O_RDWR | O_CREAT, 0600); + SAFE_UNLINK(hfile); + + if (verbose) + tst_res(TINFO, "Mapping hugepage area..."); + p = SAFE_MMAP(NULL, hpage_size, PROT_READ|PROT_WRITE, MAP_PRIVATE, fd, 0); + if (verbose) + tst_res(TINFO, "mapped at %p", p); + /* Touch the page for write in parent */ + if (verbose) + tst_res(TINFO, "Parent writes pre-fork..."); + *p = RANDOM_CONSTANT; + if (verbose) + tst_res(TINFO, "%x", RANDOM_CONSTANT); + + SAFE_SIGACTION(SIGCHLD, &sa, NULL); + + pid = SAFE_FORK(); + + if (pid != 0) { + /* Parent */ + if (verbose) + tst_res(TINFO, "Parent writes post-fork..."); + *p = ~RANDOM_CONSTANT; + if (verbose) + tst_res(TINFO, "~RANDOM_CONSTANT: %x", ~RANDOM_CONSTANT); + *trigger = 1; + + while (*trigger != 2) + ; + + if (verbose) + tst_res(TINFO, "Parent reads.."); + parent_readback = *p; + if (verbose) + tst_res(TINFO, "Parent readback: %x", parent_readback); + *trigger = 3; + } else { + /* Child */ + if (verbose) + tst_res(TINFO, "Child starts.."); + while (*trigger != 1) + ; + + if (verbose) + tst_res(TINFO, "Child reads..."); + *child_readback = *p; + if (verbose) { + tst_res(TINFO, "child readback: %x", *child_readback); + tst_res(TINFO, "Child writes..."); + } + *p = OTHER_CONSTANT; + if (verbose) + tst_res(TINFO, "OTHER_CONSTANT: %x", OTHER_CONSTANT); + + *trigger = 2; + + while (*trigger != 3) + ; + if (verbose) + tst_res(TINFO, "Child exits..."); + exit(0); + } + + if (verbose) + tst_res(TINFO, "child_readback = 0x%x, parent_readback = 0x%x\n", + *child_readback, parent_readback); + + if (*child_readback != RANDOM_CONSTANT) { + tst_res(TFAIL, "Child read back 0x%x instead of 0x%x", + *child_readback, RANDOM_CONSTANT); + goto fail; + } + if (parent_readback != ~RANDOM_CONSTANT) { + tst_res(TFAIL, "Parent read back 0x%x instead of 0x%x", + parent_readback, RANDOM_CONSTANT); + goto fail; + } + + SAFE_WAITPID(pid, &status, 0); + + tst_res(TPASS, "Successful"); + SAFE_MUNMAP((void *)p, hpage_size); + SAFE_MUNMAP(syncarea, getpagesize()); + SAFE_CLOSE(fd); + return; +fail: + tst_brk(TBROK, "Once failed, No point in continuing the test"); +} + +static void setup(void) +{ + int free_pages = SAFE_READ_MEMINFO("HugePages_Free:"); + + if (tst_hugepages < 2 || free_pages < 2) + tst_brk(TCONF, "Not enough hugepages for testing."); + + if (!Hopt) + Hopt = tst_get_tmpdir(); + SAFE_MOUNT("none", Hopt, "hugetlbfs", 0, NULL); + + snprintf(hfile, sizeof(hfile), "%s/ltp_hugetlbfile%d", Hopt, getpid()); + hpage_size = SAFE_READ_MEMINFO("Hugepagesize:")*1024; +} + +static void cleanup(void) +{ + if (fd >= 0) + SAFE_CLOSE(fd); + umount2(Hopt, MNT_DETACH); +} + +static struct tst_test test = { + .needs_root = 1, + .needs_tmpdir = 1, + .options = (struct tst_option[]) { + {"v", &verbose, "Turns on verbose mode"}, + {"H:", &Hopt, "Location of hugetlbfs, i.e. -H /var/hugetlbfs"}, + {"s:", &nr_opt, "Set the number of the been allocated hugepages"}, + {} + }, + .forks_child = 1, + .setup = setup, + .cleanup = cleanup, + .test_all = run_test, + .hugepages = {2, TST_REQUEST}, +}; -- 2.31.1 -- Mailing list info: https://lists.linux.it/listinfo/ltp