Re: [LTP] [PATCH v1] ioctl01.c:Test also struct termios

[Wei Gao via ltp <ltp@lists.linux.it>]

On Mon, Feb 06, 2023 at 07:12:11AM +0100, Petr Vorel wrote:
> Hi Wei,
> 
> > Hi Wei,
> 
> ...
> > > @@ -64,7 +66,21 @@ static void verify_ioctl(unsigned int i)
> > >  	if (TST_ERR != tcases[i].error) {
> > >  		tst_res(TFAIL | TTERRNO,
> > >  			"failed unexpectedly; expected %s",
> > > -		        tst_strerrno(tcases[i].error));
> > > +			tst_strerrno(tcases[i].error));
> > > +		return;
> > > +	}
> > Could you please replace TEST(ioctl(...) with TST_EXP_FAIL(ioctl(...))?
> > That would save all error handling.
> 
> > We try to use these helping macros in include/tst_test_macros.h.
> > Although they would deserve some docs as macros are a bit harder to read.
> 
> I implemented this in 4c86809f77 ("ioctl01: cleanup"). Could you please rebase
> your commit and use TST_EXP_FAIL() in it?
Done, could you help check it, thanks!
> 
> Thank you!
> 
> Kind regards,
> Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp