Re: [LTP] [PATCH 1/1] testscripts/network.sh: Don't load tst_net.sh

[Petr Vorel <pvorel@suse.cz>]

> Hi!
> > > This should not be needed any more for neither new API and legacy tests
> > > since 04021637f4 ("tst_test.sh: Cleanup getopts usage")
> > I suppose loading tst_net.sh was not needed even before. I wonder why this was
> > ever needed.

> > It was added in 6538f7ab70 ("network: merge networktests.sh/networkstress.sh
> > into network.sh") when testcases/lib/test_net.sh (predecessor of
> > testcases/lib/tst_net.sh) was much simpler (e.g. without netns).

> Actually it sems that it was just moved from the top of the file further
> down in that commit. It was in the git since the beginning when the file
> was added by Alexey. Maybe there were scripts that didn't include any
> shell library at that time, who knows.

> Anyways as long as all the network tests we have does include the
> library themselves let's go ahead and get rid of it.

Please read further info in my later reaction [1]
(TL;DR: not all include it, but these aren't in runtest files anyway).

Kind regards,
Petr

[1] https://lore.kernel.org/ltp/Y+NzkUcAyeupRwmP@pevik/

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp