From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 912C5C636CC for ; Wed, 8 Feb 2023 14:58:49 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 3D3663CD0B9 for ; Wed, 8 Feb 2023 15:58:47 +0100 (CET) Received: from in-3.smtp.seeweb.it (in-3.smtp.seeweb.it [IPv6:2001:4b78:1:20::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 38FE83CB0E9 for ; Wed, 8 Feb 2023 15:58:36 +0100 (CET) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-3.smtp.seeweb.it (Postfix) with ESMTPS id 74A751A002E8 for ; Wed, 8 Feb 2023 15:58:35 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id B7D691F8A6; Wed, 8 Feb 2023 14:58:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1675868314; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=C0RevJloA9vDX9xxODIlZkvhXtbiJP3Fa7hC+Mesefc=; b=oeBkT/KDXa7FSHC+UPXPT5cvsWCSlopBp2tjbyKT+pMuwzn3TYg78e8g9+RilEC90nv0WM VRrBPplmtVnKDYvfl3jhTAv47VtG5ABAQDFEORBUbib1/Y8E/uF0dNqVrUG0sk/KRU6n23 XZ4bv/7luW3Rw+rb3yizyKyCJz6gagE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1675868314; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=C0RevJloA9vDX9xxODIlZkvhXtbiJP3Fa7hC+Mesefc=; b=4ll/2B0KbhPa2SnvG0BBpRUN/JeWZvnDDy/XUBXv8FQ5J8LGs4ZA9nLk6YC2gevDfrhgrv gEu/KSPrAlU/SIBA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A31EA13425; Wed, 8 Feb 2023 14:58:34 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id KCrxJpq442O3MwAAMHmgww (envelope-from ); Wed, 08 Feb 2023 14:58:34 +0000 Date: Wed, 8 Feb 2023 15:58:33 +0100 From: Petr Vorel To: Cyril Hrubis Message-ID: <20230208145833.GB1918@pevik> References: <20230208092327.28914-1-pvorel@suse.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Virus-Scanned: clamav-milter 0.102.4 at in-3.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH 1/1] testscripts/network.sh: Don't load tst_net.sh X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" > Hi! > > > This should not be needed any more for neither new API and legacy tests > > > since 04021637f4 ("tst_test.sh: Cleanup getopts usage") > > I suppose loading tst_net.sh was not needed even before. I wonder why this was > > ever needed. > > It was added in 6538f7ab70 ("network: merge networktests.sh/networkstress.sh > > into network.sh") when testcases/lib/test_net.sh (predecessor of > > testcases/lib/tst_net.sh) was much simpler (e.g. without netns). > Actually it sems that it was just moved from the top of the file further > down in that commit. It was in the git since the beginning when the file > was added by Alexey. Maybe there were scripts that didn't include any > shell library at that time, who knows. > Anyways as long as all the network tests we have does include the > library themselves let's go ahead and get rid of it. Please read further info in my later reaction [1] (TL;DR: not all include it, but these aren't in runtest files anyway). Kind regards, Petr [1] https://lore.kernel.org/ltp/Y+NzkUcAyeupRwmP@pevik/ -- Mailing list info: https://lists.linux.it/listinfo/ltp