From: Ping Fang <pifang@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2] aiocp: remove the check read unnecessary flag
Date: Thu, 9 Feb 2023 22:20:16 +0800 [thread overview]
Message-ID: <20230209142016.494090-1-pifang@redhat.com> (raw)
When aiocp executed with -f DIRECT will fail.
<<<test_start>>>
tag=AD049 stime=1675520824
cmdline="aiocp -b 8k -n 8 -f DIRECT"
contacts=""
analysis=exit
<<<test_output>>>
tst_test.c:1560: TINFO: Timeout per run is 0h 30m 30s
aiocp.c:211: TINFO: Maximum AIO blocks: 65536
tst_device.c:585: TINFO: Use uevent strategy
aiocp.c:250: TINFO: Fill srcfile.bin with random data
aiocp.c:279: TINFO: Copy srcfile.bin -> dstfile.bin
aiocp.c:291: TINFO: Comparing srcfile.bin with dstfile.bin
aiocp.c:306: TBROK: read(3,0x7ffcd743abe0,4096) failed, returned -1: EINVAL (22)
...
The code which checks that the data has been written correctly
may wrong use the O_DIRECT flag, which may cause a failure like the
one above.
Signed-off-by: Ping Fang <pifang@redhat.com>
---
testcases/kernel/io/ltp-aiodio/aiocp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/testcases/kernel/io/ltp-aiodio/aiocp.c b/testcases/kernel/io/ltp-aiodio/aiocp.c
index bc0e209b2..6212d8ee8 100644
--- a/testcases/kernel/io/ltp-aiodio/aiocp.c
+++ b/testcases/kernel/io/ltp-aiodio/aiocp.c
@@ -297,8 +297,8 @@ static void run(void)
return;
}
- srcfd = SAFE_OPEN(srcname, srcflags | O_RDONLY, 0666);
- dstfd = SAFE_OPEN(dstname, srcflags | O_RDONLY, 0666);
+ srcfd = SAFE_OPEN(srcname, O_RDONLY, 0666);
+ dstfd = SAFE_OPEN(dstname, O_RDONLY, 0666);
reads = howmany(filesize, buffsize);
--
2.31.1
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next reply other threads:[~2023-02-09 14:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-09 14:20 Ping Fang [this message]
2023-02-09 14:24 ` [LTP] [PATCH v2] aiocp: remove the check read unnecessary flag Cyril Hrubis
2023-02-09 14:35 ` Andrea Cervesato via ltp
2023-02-10 5:27 ` Li Wang
2023-02-10 8:00 ` Li Wang
2023-02-09 14:37 ` Jan Stancek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230209142016.494090-1-pifang@redhat.com \
--to=pifang@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox