From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9ACC5C678D4 for ; Thu, 2 Mar 2023 10:47:34 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 6D24A3CCDFC for ; Thu, 2 Mar 2023 11:47:32 +0100 (CET) Received: from in-3.smtp.seeweb.it (in-3.smtp.seeweb.it [217.194.8.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id F00463CB9CF for ; Thu, 2 Mar 2023 11:47:21 +0100 (CET) Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-3.smtp.seeweb.it (Postfix) with ESMTPS id 77BCE1A00CC9 for ; Thu, 2 Mar 2023 11:47:21 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id A4DD11FE65; Thu, 2 Mar 2023 10:47:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1677754040; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rDpkYi6l28OUZ543X0lsOi/fUjGlhsA2DPoTtul99xU=; b=NGKNmT5vl7RpNvPQDA5cznHeB0oRsjf5qTU256nBDN/lOrXiJu6QbtTms+mD89nqW8rvz3 IARVb3TiqE3X1wuQLu3NZFQlKUegkWg674k03EQj0hCspNbiu9Rwn4C3tJZkL+lmBjhOSp KCFxcRGa3FX60v7OwrJ/jTWmRlqAqS0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1677754040; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rDpkYi6l28OUZ543X0lsOi/fUjGlhsA2DPoTtul99xU=; b=9UHOPZeoQ2+cMQKMdfGhfs7Mwdwoxo5fg/W+5JM5yo+xIs+Qt2pYxHJ/Omp9Ugz4b7EnqV CLLZplKQorP9SbDA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 72D4313349; Thu, 2 Mar 2023 10:47:20 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 7vJsGbh+AGQ9ZgAAMHmgww (envelope-from ); Thu, 02 Mar 2023 10:47:20 +0000 Date: Thu, 2 Mar 2023 11:47:18 +0100 From: Petr Vorel To: Martin Doucha Message-ID: <20230302104718.GA3854@pevik> References: <20230302103552.10800-1-mdoucha@suse.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230302103552.10800-1-mdoucha@suse.cz> X-Virus-Scanned: clamav-milter 0.102.4 at in-3.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH] fsconfig03: Fix return value validation on older kernels X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi Martin, > On older kernels, Btrfs is not the only filesystem using the legacy > fsconfig() handlers. Assume that fsconfig() is using legacy_parse_param() > and allow it to return success regardless of filesystem up until the point > where the legacy buffer would get full. LGTM, thanks! Reviewed-by: Petr Vorel > Signed-off-by: Martin Doucha > --- > Tested on kernel 5.3 both with and without the CVE fix. Obviously still works on new kernel as well (tested on 6.1.x). Kind regards, Petr -- Mailing list info: https://lists.linux.it/listinfo/ltp