Re: [LTP] [PATCH v2] mprotect: Add mprotect05 testcase

[Petr Vorel <pvorel@suse.cz>]

Hi Liam,

> Add a test that uses mprotect to split and combine VMAs.  Created to
> ensure the correctness of the VMA iterator after a bug report.

LGTM, thank you.

Reviewed-by: Petr Vorel <pvorel@suse.cz>

...
> +/*\
> + * [Description]
> + *
> + *	Testcase to check the mprotect(2) system call split and merge
> + *
> + * Reference links:
> + *  - https://bugzilla.kernel.org/show_bug.cgi?id=217061
This would be formatted as inline in our docs.
> + *
> + */
> +
> +#include <errno.h>
> +#include <stdio.h>
These aren't needed.

Waiting little longer for any feedback before merging with the diff below.

Kind regards,
Petr

+++ testcases/kernel/syscalls/mprotect/mprotect05.c
@@ -9,14 +9,10 @@
  *
  *	Testcase to check the mprotect(2) system call split and merge
  *
- * Reference links:
- *  - https://bugzilla.kernel.org/show_bug.cgi?id=217061
+ * https://bugzilla.kernel.org/show_bug.cgi?id=217061
  *
  */
 
-#include <errno.h>
-#include <stdio.h>
-
 #include "tst_test.h"
 
 #define TEST_FILE "mprotect05-testfile"

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp