From: Petr Vorel <pvorel@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.com>
Cc: Richard Palethorpe <rpalethorpe@suse.com>, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v5 4/6] Refactor mqns_04 using new LTP API
Date: Fri, 3 Mar 2023 10:16:03 +0100 [thread overview]
Message-ID: <20230303091603.GC4255@pevik> (raw)
In-Reply-To: <20230301152818.4427-5-andrea.cervesato@suse.com>
Hi Andrea,
+++ b/testcases/kernel/containers/mqns/mqns_04.c
...
> + tst_res(TINFO, "Try to create %s from parent", mqueue2);
> - mkdir(DEV_MQUEUE2, 0755);
> + TST_EXP_FAIL(creat(mqueue2, 0755), EACCES);
OK, you created MQNAME2 (asked by Richie in v4).
> + if (!TST_PASS)
> + tst_atomic_inc(mq_freed2);
> - tst_resm(TINFO, "Checking mqueue filesystem lifetime");
> + SAFE_UMOUNT(devdir);
> +}
I suppose it does not make sense to spawn plain process as it's done in
mqns_03.c, right?
Maybe it'd be worth to mention clone and unshare modes in [Description].
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2023-03-03 8:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-01 15:28 [LTP] [PATCH v5 0/6] Refactor mqns testing suite Andrea Cervesato via ltp
2023-03-01 15:28 ` [LTP] [PATCH v5 1/6] Refactor mqns_01 using new LTP API Andrea Cervesato via ltp
2023-03-01 15:28 ` [LTP] [PATCH v5 2/6] Refactor mqns_02 " Andrea Cervesato via ltp
2023-03-01 15:28 ` [LTP] [PATCH v5 3/6] Refactor mqns_03 " Andrea Cervesato via ltp
2023-03-03 9:25 ` Petr Vorel
2023-03-03 8:46 ` Andrea Cervesato via ltp
2023-03-03 10:22 ` Petr Vorel
2023-03-01 15:28 ` [LTP] [PATCH v5 4/6] Refactor mqns_04 " Andrea Cervesato via ltp
2023-03-03 9:16 ` Petr Vorel [this message]
2023-03-03 8:45 ` Andrea Cervesato via ltp
2023-03-01 15:28 ` [LTP] [PATCH v5 5/6] Remove deprecated header files from mqns suite Andrea Cervesato via ltp
2023-03-01 15:28 ` [LTP] [PATCH v5 6/6] Remove libclone dependency " Andrea Cervesato via ltp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230303091603.GC4255@pevik \
--to=pvorel@suse.cz \
--cc=andrea.cervesato@suse.com \
--cc=ltp@lists.linux.it \
--cc=rpalethorpe@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox