From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6C91DC678D4 for ; Fri, 3 Mar 2023 08:25:56 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 0D4043CB992 for ; Fri, 3 Mar 2023 09:25:54 +0100 (CET) Received: from in-6.smtp.seeweb.it (in-6.smtp.seeweb.it [217.194.8.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 3A4043CAC12 for ; Fri, 3 Mar 2023 09:25:43 +0100 (CET) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-6.smtp.seeweb.it (Postfix) with ESMTPS id 6EC421400C42 for ; Fri, 3 Mar 2023 09:25:42 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id B69062298D; Fri, 3 Mar 2023 08:25:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1677831941; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=X0O6bjbTvNVR+55VFT9Q/3iU6zj14iLqIVvMHXkl+kA=; b=ztZVETxMB9ms+f7OzCyqHvXkMy3aGyqrds4/g4f256ZICbW5EBSKKAzPu0lYfjdqBzxNfN f3a+GvolBPyDiovQjZnpkSlsg/hdSkBr/gppfksv++niGkYkNg94oJ8Vzq37ZtjgnMlwOC d2JWZGF54iSKktd62ulqODKuU8xTQ70= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1677831941; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=X0O6bjbTvNVR+55VFT9Q/3iU6zj14iLqIVvMHXkl+kA=; b=1sH1RWAcJ/pbojEqQBnJOA6bC1r2AbMU2odsJROLCZehxYG3jYcXn1mTu+HHy8dnwPhI6K TNdSteUBkPyWq4Cw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6F8B2139D3; Fri, 3 Mar 2023 08:25:41 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 1rz3FwWvAWQnSgAAMHmgww (envelope-from ); Fri, 03 Mar 2023 08:25:41 +0000 Date: Fri, 3 Mar 2023 10:16:03 +0100 From: Petr Vorel To: Andrea Cervesato Message-ID: <20230303091603.GC4255@pevik> References: <20230301152818.4427-1-andrea.cervesato@suse.com> <20230301152818.4427-5-andrea.cervesato@suse.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230301152818.4427-5-andrea.cervesato@suse.com> X-Virus-Scanned: clamav-milter 0.102.4 at in-6.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v5 4/6] Refactor mqns_04 using new LTP API X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Cc: Richard Palethorpe , ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi Andrea, +++ b/testcases/kernel/containers/mqns/mqns_04.c ... > + tst_res(TINFO, "Try to create %s from parent", mqueue2); > - mkdir(DEV_MQUEUE2, 0755); > + TST_EXP_FAIL(creat(mqueue2, 0755), EACCES); OK, you created MQNAME2 (asked by Richie in v4). > + if (!TST_PASS) > + tst_atomic_inc(mq_freed2); > - tst_resm(TINFO, "Checking mqueue filesystem lifetime"); > + SAFE_UMOUNT(devdir); > +} I suppose it does not make sense to spawn plain process as it's done in mqns_03.c, right? Maybe it'd be worth to mention clone and unshare modes in [Description]. Reviewed-by: Petr Vorel Kind regards, Petr -- Mailing list info: https://lists.linux.it/listinfo/ltp