From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 914E6C678D5 for ; Wed, 8 Mar 2023 08:42:53 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id DB7C33CB847 for ; Wed, 8 Mar 2023 09:42:50 +0100 (CET) Received: from in-7.smtp.seeweb.it (in-7.smtp.seeweb.it [217.194.8.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 770383CB82D for ; Wed, 8 Mar 2023 09:42:40 +0100 (CET) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-7.smtp.seeweb.it (Postfix) with ESMTPS id D96602009C2 for ; Wed, 8 Mar 2023 09:42:39 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 3BE751FE35; Wed, 8 Mar 2023 08:42:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1678264959; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=P6XJ+rzi/OfIkJSZNDR2NWIZclpyzj2U41ifmXmKcR0=; b=dvdRSswMikKvhBs7q/XZV+5IML9bPXX7Zwb+bWzbdf5pJQc2TayZj+aZnpET6BP7hbJ1FO aioiJC7PL1yAW9CDBAmqhQ27gOZAHozcPbOsfHIBEG38RYQSM2vIjpcJE4gWBIa+WXjOg0 /Mxk+lp1pGd7uk6ry1u7ajmf4WutaEc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1678264959; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=P6XJ+rzi/OfIkJSZNDR2NWIZclpyzj2U41ifmXmKcR0=; b=b/yA8vvdnC8RYtfxuRrxUWGIp3+m3h/S4DwvwffqiSV9EXrRT5khl2iH5CYSC6xXGjk/Nj LS806xYzCIgzWqAg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 189CF1348D; Wed, 8 Mar 2023 08:42:39 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 04SwA39KCGQeIAAAMHmgww (envelope-from ); Wed, 08 Mar 2023 08:42:39 +0000 Date: Wed, 8 Mar 2023 09:42:36 +0100 From: Petr Vorel To: Andrea Cervesato Message-ID: <20230308084236.GA16831@pevik> References: <20230301091737.32083-1-andrea.cervesato@suse.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230301091737.32083-1-andrea.cervesato@suse.com> X-Virus-Scanned: clamav-milter 0.102.4 at in-7.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v1] Rewrite ns_create using new LTP API X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi Andrea, > +/*\ > + * [Description] nit: ns_create is a tool, not a test, therefore I would not add [Description] (similarly e.g. nfs05_make_tree.c does not define it), but it's a detail, let's keep it. > * > - *********************************************************************** > * Creates a child process in the new specified namespace(s), child is then > * daemonized and is running in the background. PID of the daemonized child > * process is printed on the stdout. As the new namespace(s) is(are) maintained > * by the daemonized child process it(they) can be removed by killing this > * process. > - * > */ Reviewed-by: Petr Vorel Kind regards, Petr -- Mailing list info: https://lists.linux.it/listinfo/ltp