Re: [LTP] [PATCH] configure.ac: fix mount_attr detection

[Petr Vorel <pvorel@suse.cz>]

Hi Li,

> On Fri, Mar 10, 2023 at 5:31 PM Petr Vorel <pvorel@suse.cz> wrote:

> > Hi all,

> > ...
> > > > I wonder if we can get this whole mess of two different fallback
> > headers
> > > > simplified. Looking at the glibc implementation it seems to include
> > > > "linux/mount.h" if it does exist. So most reasonable solution would do
> > > > the same I guess which we did before the commit you reference.


> > > This is indeed correct if only face the latest Glibc, but that might have
> > > problems when building LTP on a middle version of Glibc/Kernel-headers.
> > > The bug I mentioned in the last email was fixed since glibc-2.37~426.
> > Do you know which exact commit has fixed it? It'd help us to realize when
> > this
> > fix is not needed any more (it'd be good to put it into the commit
> > message).


> I mean this commit:
> https://github.com/kraj/glibc/commit/774058d72942249f71d74e7f2b639f77184160a6

Thanks for info. Fix from 2.37, it was also cherry picked to release/2.36/master
branch, but not to branches for older releases (2.35 and 2.34).

I suppose there will be always some toolchain/distro with older glibc without
this fix, thus I'd merge it now, and made simplification Cyril suggested
sometimes next year.

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp