Re: [LTP] [PATCH v3 1/2] Move semaphore/ tests to semop/

[Wei Gao via ltp <ltp@lists.linux.it>]

On Wed, Mar 15, 2023 at 01:31:19PM +0100, Petr Vorel wrote:
> Hi Wei,
> 
> > There is no point in having two different directories with semop()
> > testcaes so it would make sense to move these two tests into the
> > syscalls/ipc/semop/ directory as semop04 and semop05.
> > So we move ipc/semaphore/ tests to syscalls/ipc/semop/.
> > Also update runtest files accordingly.
> 
> As I already stated, I'm not really sure this is good to do, but maybe I'm
> missing something.  I wonder what others thing about it.
> 
Ah, you also start work on this?  Should i still continue work on this patch or not?
To me this is not bad thing at least, we do some clean work and reorganize the test cases.
> ...
> >  rename testcases/kernel/{ipc/semaphore/sem01.c => syscalls/ipc/semop/semop04.c} (100%)
> >  rename testcases/kernel/{ipc/semaphore/sem02.c => syscalls/ipc/semop/semop05.c} (100%)
> 
> > +++ b/runtest/syscalls
> > @@ -1239,6 +1239,8 @@ semget06 semget06
> >  semop01 semop01
> >  semop02 semop02
> >  semop03 semop03
> > +semop04 semop04
> > +semop05 semop05
> You renamed files, you need to remove sem01 sem02 from runtest/ipc.
Ack!
> 
> Kind regards,
> Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp