public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Richard Palethorpe <rpalethorpe@suse.com>, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] Add goals of patch review and tips
Date: Mon, 20 Mar 2023 09:04:15 +0100	[thread overview]
Message-ID: <20230320080415.GA179863@pevik> (raw)
In-Reply-To: <20230314175438.GB79562@pevik>

Hi all,

...
> > +## Maintainers Checklist

> >  Patchset should be tested locally and ideally also in maintainer's fork in
> >  GitHub Actions on GitHub.
> I'd encourage people to enable GitHub Actions in their forks (I'm not sure how

> many maintainers do this; best would be automation [1] [2], but nobody bothers
> about CI and I'm sort of burn out driving it myself).

+ also add Tested: link-to-github-actions-run below --- in patch would help
(it's than obvious that maintainer does not have to bother with doing it or
not hope that it fails on CentOS 7 old compiler or very new Fedora compiler).

Maybe also encourage people to create account in the patchwork and maintain
status their patches would help (set "Superseded" if they sent new patch version,
other statuses like "Accepted" or "Changes requested" are also sometimes
forgotten by the maintainer who post comments or merge the patch).

Both of these are small helps, but they still help LTP maintainers to have more
time for the review or for writing own patches.

But I can post a follow-up patch with these after your patch is merged if you
don't want to formulate them.

Kind regards,
Petr

> Kind regards,
> Petr

> [1] https://github.com/linux-test-project/ltp/issues/599
> [2] https://github.com/linux-test-project/ltp/issues/600

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  parent reply	other threads:[~2023-03-20  8:04 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-14 11:40 [LTP] [PATCH] Add goals of patch review and tips Richard Palethorpe via ltp
2023-03-14 13:18 ` Cyril Hrubis
2023-03-16 10:18   ` Richard Palethorpe
2023-03-22 16:48     ` Cyril Hrubis
2023-03-23  5:46       ` Petr Vorel
2023-03-14 17:54 ` Petr Vorel
2023-03-14 18:16   ` Cyril Hrubis
2023-03-16 10:51   ` Richard Palethorpe
2023-03-20  8:04   ` Petr Vorel [this message]
2023-03-20  8:23     ` Petr Vorel
2023-03-20  8:33       ` Petr Vorel
2023-03-20  9:25       ` Richard Palethorpe
2023-03-20 14:48         ` Petr Vorel
2023-03-20 11:16       ` Li Wang
2023-03-20 14:37         ` Petr Vorel
2023-03-22 16:49         ` Cyril Hrubis
2023-03-23  5:42           ` Petr Vorel
2023-03-22 16:43       ` Cyril Hrubis
2023-05-16 12:08 ` Petr Vorel
2023-05-18 10:56   ` Richard Palethorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230320080415.GA179863@pevik \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    --cc=rpalethorpe@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox