From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: Richard Palethorpe <rpalethorpe@suse.com>, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] Add goals of patch review and tips
Date: Thu, 23 Mar 2023 06:42:46 +0100 [thread overview]
Message-ID: <20230323054246.GB381848@pevik> (raw)
In-Reply-To: <ZBsxm5o82a5CZ4my@yuki>
> Hi!
> > I'd make a clarification for that mknod01 patch review,
> > the reason why Cyril merge V1 manually is that V2
> > involves new change (I neglected) in mknod02, which
> > should be separated in another patch.
> > Cyril did the right thing there. But he didn't explain that.
> I did the right thing by accident though. I only realized there is v2
> later on...
I really didn't want to blame anybody. I just wanted to demonstrate occasional
problems due wrong patch setup in patchwork. Therefore I proposed to all active
developers including these who aren't LTP maintainers (we have quite a few from
SUSE) to maintain their *latest* version of the patchset in patchwork (just to
set the older version either "Superseded" or "Changes requested". That would
reduce these confusions.
I'm ok not to make it as a written rule (it might lead to confusion to encourage
all contributors to make a patchwork account, OTOH it's useful even for rare
kernel contributions, thus I have patchwork accounts in both
https://patchwork.ozlabs.org/ and https://patchwork.kernel.org/).
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2023-03-23 5:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 11:40 [LTP] [PATCH] Add goals of patch review and tips Richard Palethorpe via ltp
2023-03-14 13:18 ` Cyril Hrubis
2023-03-16 10:18 ` Richard Palethorpe
2023-03-22 16:48 ` Cyril Hrubis
2023-03-23 5:46 ` Petr Vorel
2023-03-14 17:54 ` Petr Vorel
2023-03-14 18:16 ` Cyril Hrubis
2023-03-16 10:51 ` Richard Palethorpe
2023-03-20 8:04 ` Petr Vorel
2023-03-20 8:23 ` Petr Vorel
2023-03-20 8:33 ` Petr Vorel
2023-03-20 9:25 ` Richard Palethorpe
2023-03-20 14:48 ` Petr Vorel
2023-03-20 11:16 ` Li Wang
2023-03-20 14:37 ` Petr Vorel
2023-03-22 16:49 ` Cyril Hrubis
2023-03-23 5:42 ` Petr Vorel [this message]
2023-03-22 16:43 ` Cyril Hrubis
2023-05-16 12:08 ` Petr Vorel
2023-05-18 10:56 ` Richard Palethorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230323054246.GB381848@pevik \
--to=pvorel@suse.cz \
--cc=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=rpalethorpe@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox