From: Edward Liaw via ltp <ltp@lists.linux.it>
To: ltp@lists.linux.it
Cc: kernel-team@android.com
Subject: [LTP] [PATCH v3 0/4] tst_device.c: Handle Android path for backing device
Date: Fri, 24 Mar 2023 00:24:37 +0000 [thread overview]
Message-ID: <20230324002441.987778-1-edliaw@google.com> (raw)
e1b1ae66b240 ("tst_find_backing_dev: Get dev name from
/sys/dev/block/*/uevent") added a hardcoded path to check for the
backing device in /dev. On Android, it needs to check /dev/block.
The set_dev_path function was renamed to set_dev_loop_path and its
return value was changed from 1 on success to 0 on success to be more
consistent with other functions. A check was added to
tst_find_free_loopdev in the event that the loop device is not ready
yet, which appears to happen occasionally on Android.
v1->v2:
Changed the function signature of tst_find_backing_dev to add the length
of the path string. Updated all references for this function to include
the added parameter.
v2->v3:
Split the function rename, return value change, and the return value
check into 3 commits. Fixed logic for non-NULL path check. Added Fixes
tag for e1b1ae66b240.
Edward Liaw (4):
set_dev_path: Rename to set_dev_loop_path
set_dev_loop_path: Change return value to zero on success
tst_find_free_loopdev: Check return value of set_dev_loop_path
tst_find_backing_dev: Also check /dev/block/ for backing device
doc/c-test-api.txt | 2 +-
include/tst_device.h | 3 +-
lib/newlib_tests/tst_device.c | 2 +-
lib/tst_device.c | 51 ++++++++++++-------
.../kernel/syscalls/ioctl/ioctl_loop05.c | 2 +-
5 files changed, 38 insertions(+), 22 deletions(-)
--
2.40.0.348.gf938b09366-goog
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next reply other threads:[~2023-03-24 0:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-24 0:24 Edward Liaw via ltp [this message]
2023-03-24 0:24 ` [LTP] [PATCH v3 1/4] set_dev_path: Rename to set_dev_loop_path Edward Liaw via ltp
2023-03-27 7:43 ` Petr Vorel
2023-03-24 0:24 ` [LTP] [PATCH v3 2/4] set_dev_loop_path: Change return value to zero on success Edward Liaw via ltp
2023-03-27 7:43 ` Petr Vorel
2023-03-24 0:24 ` [LTP] [PATCH v3 3/4] tst_find_free_loopdev: Check return value of set_dev_loop_path Edward Liaw via ltp
2023-03-27 7:44 ` Petr Vorel
2023-03-24 0:24 ` [LTP] [PATCH v3 4/4] tst_find_backing_dev: Also check /dev/block/ for backing device Edward Liaw via ltp
2023-03-27 9:36 ` Petr Vorel
2023-03-27 15:26 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230324002441.987778-1-edliaw@google.com \
--to=ltp@lists.linux.it \
--cc=edliaw@google.com \
--cc=kernel-team@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox