From: Petr Vorel <pvorel@suse.cz>
To: Edward Liaw <edliaw@google.com>
Cc: kernel-team@android.com, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2] setpgid02: use 1 instead of getpgid(1)
Date: Fri, 31 Mar 2023 08:14:46 +0200 [thread overview]
Message-ID: <20230331061446.GA1043774@pevik> (raw)
In-Reply-To: <20230331000747.2294390-1-edliaw@google.com>
Hi Edward,
> On Android, init does not setpgid, so getpgid(1) returns 0 and the third
> case of setting pgid to a different session's process group does not
> behave as expected: setpgid treats 0 as setting the pgid to the pid.
> Instead, replace SAFE_GETPGID(1) with the expected value of 1.
Seems to be safe.
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2023-03-31 6:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-31 0:07 [LTP] [PATCH v2] setpgid02: use 1 instead of getpgid(1) Edward Liaw via ltp
2023-03-31 6:14 ` Petr Vorel [this message]
2023-03-31 6:45 ` Avinesh Kumar
2023-04-07 10:18 ` Teo Couprie Diaz
2023-04-10 23:51 ` Edward Liaw via ltp
2023-04-11 10:35 ` Teo Couprie Diaz
2023-04-11 23:05 ` Petr Vorel
2023-04-12 11:45 ` Teo Couprie Diaz
2023-06-28 9:16 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230331061446.GA1043774@pevik \
--to=pvorel@suse.cz \
--cc=edliaw@google.com \
--cc=kernel-team@android.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox