From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 28312C6FD18 for ; Fri, 31 Mar 2023 06:15:03 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id E85B03CC9BB for ; Fri, 31 Mar 2023 08:15:00 +0200 (CEST) Received: from in-4.smtp.seeweb.it (in-4.smtp.seeweb.it [IPv6:2001:4b78:1:20::4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 313743CC92F for ; Fri, 31 Mar 2023 08:14:49 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-4.smtp.seeweb.it (Postfix) with ESMTPS id 49B6010002BE for ; Fri, 31 Mar 2023 08:14:48 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 5D43321AE1; Fri, 31 Mar 2023 06:14:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1680243288; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cDs3zeuvquE7bSkDGEh+9qzB1BCFaSJpTGCoNYsaV8M=; b=sD1O2KIiRikbrbn4V/lw62xLrSicXVN12cyB3VuAYsuQ06roY3lSno6eMeThprL8RgxkWc g+u1fFSBjpG0CqQ14XbbkktCg4mH6ok5/IbSb3Tap19Yl/KHHtiNssBIhG9FX+eEXBFMYu IfUGNrmWTfZfIvz+vq6ByQDdIdLkpvU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1680243288; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cDs3zeuvquE7bSkDGEh+9qzB1BCFaSJpTGCoNYsaV8M=; b=FpTf9T6zURfU3JEmz/46+J4AjHpeYWHYj8fSJxW97PEkPxa0t5yXxDQKAadYZSmDLIvKWz uVwFhD7csBYM/ZDQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 42837133B6; Fri, 31 Mar 2023 06:14:48 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id XAsxD1h6JmTVUgAAMHmgww (envelope-from ); Fri, 31 Mar 2023 06:14:48 +0000 Date: Fri, 31 Mar 2023 08:14:46 +0200 From: Petr Vorel To: Edward Liaw Message-ID: <20230331061446.GA1043774@pevik> References: <20230331000747.2294390-1-edliaw@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230331000747.2294390-1-edliaw@google.com> X-Virus-Scanned: clamav-milter 0.102.4 at in-4.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v2] setpgid02: use 1 instead of getpgid(1) X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Cc: kernel-team@android.com, ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi Edward, > On Android, init does not setpgid, so getpgid(1) returns 0 and the third > case of setting pgid to a different session's process group does not > behave as expected: setpgid treats 0 as setting the pgid to the pid. > Instead, replace SAFE_GETPGID(1) with the expected value of 1. Seems to be safe. Reviewed-by: Petr Vorel Kind regards, Petr -- Mailing list info: https://lists.linux.it/listinfo/ltp