Re: [LTP] [PATCH] Added test for mmap() with MAP_SHARED_VALIDATE.

Li Wang
2023-03-28T08:30:53Z

On Tue, Mar 28, 2023 at 4:17 PM Petr Vorel <pvorel@suse.cz> wrote:
>
> Hi Li,
>
> > Hi Paulson, Petr,
>
> > Paulson Raja L <lpaulsonraja@gmail.com> wrote:
>
> > > Hi Petr Vorel,
> > > Thanks for the comments, I have just started contributing to LTP, and
> > > this is my first patch. I agree to merge it as is.
>
> > Good to see a new case for MAP_SHARED_VALIDATE.
>
> > As this is the first test to cover the new flags argument, so I'm
> > wondering can we add the functional verification to check if
> > this works correctly for mapping a valid shared memory which
> > equal to the behavior of MAP_SHARED?
> > (or do this in a separate patch)
> +1
>
> > But anyway, I'd suggest you send a patch V2 for achieving all
> > requested changes.
>
> Li, if you don't mind, I'll merge "v2" I prepared [1] (part of
> paulson/mmap.fixes branch in my fork). Can I add your Reviewed-by tag? As the
> work is already done, I'd prefer to postpone the work you propose to separate
> patch after.

Of course yes!! Feel free to do that.

My suggestion is only to Paulson for familiarity with the patch
contribute workflow,
but he can get to know this by your operation too.

--
Regards,
Li Wang