Re: [LTP] [PATCH] Added test for mmap() with MAP_SHARED_VALIDATE.

Petr Vorel
2023-03-28T08:17:27Z

Hi Li,

> Hi Paulson, Petr,

> Paulson Raja L <lpaulsonraja@gmail.com> wrote:

> > Hi Petr Vorel,
> > Thanks for the comments, I have just started contributing to LTP, and
> > this is my first patch. I agree to merge it as is.

> Good to see a new case for MAP_SHARED_VALIDATE.

> As this is the first test to cover the new flags argument, so I'm
> wondering can we add the functional verification to check if
> this works correctly for mapping a valid shared memory which
> equal to the behavior of MAP_SHARED?
> (or do this in a separate patch)
+1

> But anyway, I'd suggest you send a patch V2 for achieving all
> requested changes.

Li, if you don't mind, I'll merge "v2" I prepared [1] (part of
paulson/mmap.fixes branch in my fork). Can I add your Reviewed-by tag? As the
work is already done, I'd prefer to postpone the work you propose to separate
patch after.

Kind regards,
Petr

[1] https://github.com/pevik/ltp/blob/36ebc4d8900ea8438dc7839f03b7921f0ed9243a/testcases/kernel/syscalls/mmap/mmap20.c