From: Petr Vorel <pvorel@suse.cz>
To: Hao Zeng <zenghao@kylinos.cn>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] testcases:Fix the failure of shell script to get path
Date: Tue, 4 Apr 2023 15:36:50 +0200 [thread overview]
Message-ID: <20230404133650.GA1283114@pevik> (raw)
In-Reply-To: <20230404022808.925841-1-zenghao@kylinos.cn>
> For example, in the file testcases/kernel/controllers/cpuset/cpuset_funcs.sh, if the path is obtained by
> find "$CPUSET" -type d | sort | sed -n '2,$p' | tac | while read subdir, the escaped characters will be lost,
> and by adding the -r option, the escaped characters will be kept as they are without escaping
> The errors are as follows:
> /opt/ltp/testcases/bin/cpuset_funcs.sh:line178: /dev/cpuset/machine.slice/machine-qemux2d157x2dzhx2dsxf.scope/vcpu7/tasks: The file or directory is not available
Could you print the path how it looks like with ls:
ls -l /dev/cpuset/machine.slice/
FYI cgroup tests written in shell are broken by design, we write new tests in C.
Not sure if these old tests are relevant enough to be rewritten into C.
...
> +++ b/testcases/open_posix_testsuite/scripts/generate-makefiles.sh
> @@ -312,7 +312,7 @@ generate_locate_test_makefile buildonly '.test' "$buildonly_compiler_args"
> generate_locate_test_makefile runnable '.run-test'
> generate_locate_test_makefile test-tools ''
> -find . -name Makefile.1 -exec dirname {} \; | while read dir; do
> +find . -name Makefile.1 -exec dirname {} \; | while read -r dir; do
I don't think it's needed for open posix.
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next parent reply other threads:[~2023-04-04 13:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230404022808.925841-1-zenghao@kylinos.cn>
2023-04-04 13:36 ` Petr Vorel [this message]
2023-04-06 2:58 ` [LTP] [PATCH] testcases:Fix the failure of shell script to get path zenghao
2023-04-04 3:33 曾浩
2023-05-05 17:41 ` Petr Vorel
2023-05-06 9:31 ` Hao Zeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230404133650.GA1283114@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
--cc=zenghao@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox