public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Martin Doucha <mdoucha@suse.cz>,
	ltp@lists.linux.it,
	Nikita Yushchenko <nikita.yushchenko@virtuozzo.com>
Subject: Re: [LTP] [PATCH] nfs_flock: fail the test if lock/unlock ops fail
Date: Sat, 29 Apr 2023 21:28:22 +0200	[thread overview]
Message-ID: <20230429192822.GA3588012@pevik> (raw)
In-Reply-To: <YeHXEvfvnnc1WGfC@pevik>

Hi all,

> Hi Martin, Nikita,

> > The test program is quite short and simple. Why not rewrite it using the
> > current LTP API and make it even better? Some useful links to help with
> > that:

> +1

> It might not make it into this release due git freeze [1],
> but definitely worth of doing it.
> Thus I'd accept this patch for upcoming release.

I'm sorry I completely forgot on this patch. I merged it, because it
immediately stops broken test on NFS v3, which would otherwise timeout.

The problem itself would deserve debugging. If it's WONFTFIX due rpcbind
just not working on netns on NFS v3 [2], we should remove nfslock3t_01 and
nfslock3t_ipv6_01 from runtest/net.nfs and disable with TCONF NFS v3 (i.e. -v 3)
in nfslock01.sh. I'll try to not forget on posting a RFC patch to linux-nfs ML.

Kind regards,
Petr

[2] https://lore.kernel.org/ltp/3cb5de6e-6f8f-e46a-96bd-a3d88a871f3a@virtuozzo.com/


> Kind regards,
> Petr

> > https://github.com/linux-test-project/ltp/wiki/C-Test-Case-Tutorial
> > https://github.com/linux-test-project/ltp/wiki/C-Test-API
> > https://github.com/linux-test-project/ltp/wiki/Test-Writing-Guidelines

> [1] https://lore.kernel.org/ltp/YeFGwLzrR3t%2FVQLq@yuki/

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

      reply	other threads:[~2023-04-29 19:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-12 16:19 [LTP] [PATCH] nfs_flock: fail the test if lock/unlock ops fail Nikita Yushchenko via ltp
2022-01-12 16:19 ` [LTP] [PATCH] nfs_lib.sh: run exportfs at "server side" in LTP_NETNS case Nikita Yushchenko via ltp
2022-01-13 15:50   ` Petr Vorel
2022-01-13 16:27     ` Nikita Yushchenko via ltp
2022-01-14 20:23       ` Petr Vorel
2022-01-14 21:29         ` Nikita Yushchenko via ltp
2022-01-13 17:21 ` [LTP] [PATCH] nfs_flock: fail the test if lock/unlock ops fail Petr Vorel
2022-01-14  9:31 ` Martin Doucha
2022-01-14 20:03   ` Petr Vorel
2023-04-29 19:28     ` Petr Vorel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230429192822.GA3588012@pevik \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    --cc=mdoucha@suse.cz \
    --cc=nikita.yushchenko@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox