From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 934F0C77B75 for ; Wed, 3 May 2023 10:08:16 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id E72613CB8EA for ; Wed, 3 May 2023 12:08:13 +0200 (CEST) Received: from in-5.smtp.seeweb.it (in-5.smtp.seeweb.it [IPv6:2001:4b78:1:20::5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 021363CB81E for ; Wed, 3 May 2023 12:08:03 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-5.smtp.seeweb.it (Postfix) with ESMTPS id 3FE096007B7 for ; Wed, 3 May 2023 12:08:02 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 86ED9201FB; Wed, 3 May 2023 10:08:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1683108482; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MhPsvIP/Fl+OgQ3SSydGb9NzwtjpVSqpig6DpUyvgs4=; b=U4HMnoGzjneJMvxLGbJL7hFumNEzo7qN8humBtlp6gD4DAQSqnsf/tyyZIYgtNUhC7sHmR 2kgHUUZxrFkhaHNQHBLwekWVYQ6zrvU85Qvw1M/zDd0eafOriQk4xVSMHmM3MBSouw+tJf hLkFKFssXlZPOI5lT5jPVDZH/krdhEs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1683108482; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MhPsvIP/Fl+OgQ3SSydGb9NzwtjpVSqpig6DpUyvgs4=; b=MR+GCoYfaGGj4hPX4H8TdSQ2w0ik6zkjL9cKlRAAFnC87OMovi4eZCPeROSLKNnTV4xaFA 3MC+wJz+yyvM1pDw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 33C4D1331F; Wed, 3 May 2023 10:08:02 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id ewrXB4IyUmRWKwAAMHmgww (envelope-from ); Wed, 03 May 2023 10:08:02 +0000 Date: Wed, 3 May 2023 12:08:15 +0200 From: Petr Vorel To: ltp@lists.linux.it, NeilBrown , linux-nfs@vger.kernel.org Message-ID: <20230503100815.GA3716045@pevik> References: <20230428160038.3534905-1-pvorel@suse.cz> <20230428160038.3534905-4-pvorel@suse.cz> <20230428170330.GA3536627@pevik> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230428170330.GA3536627@pevik> X-Virus-Scanned: clamav-milter 0.102.4 at in-5.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v4 3/4] nfs05.sh: Lower down the default values X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi all, > Hi all, > > nfs05_make_tree.c runs make which needs on Btrfs quite a lot of > > temporary space. This is a preparation for the next commit which > > start using all filesystems via TST_ALL_FILESYSTEMS=1. Currently we use > > 300 MB, which was not enough for Btrfs: > Also, based on this detection we could add support for tst_device acquire SIZE > into tst_test.sh to support more than the default 300 MB (as we see the actual > use is obviously less for some filesystems). This would need to check size with > tst_fs_has_free. > Even we don't add this feature, it'd be more friendly to check for space > before creating the loop device: > if ! tst_fs_has_free $TST_TMPDIR 300MB; then > tst_brkm TCONF "Insufficient disk space to create a backing file for loop device" > fi > To be honest, I'd like to merge this patchset first, the rest can wait after the > release. > Kind regards, > Petr > > Filesystem Type Size Used Avail Use% Mounted on > > /dev/loop0 btrfs 300M 62M 20K 100% /tmp/LTP_nfs05.Vau10kcszO/mntpoint > > After lowering the default values 96% (58M) is being used. > > Proper solution would be to detect available size in nfs05_make_tree.c > > and lower down values based on free space. > > Signed-off-by: Petr Vorel > > --- > > New in v4. > > testcases/network/nfs/nfs_stress/nfs05.sh | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/testcases/network/nfs/nfs_stress/nfs05.sh b/testcases/network/nfs/nfs_stress/nfs05.sh > > index c18ef1ab4..34151b67a 100755 > > --- a/testcases/network/nfs/nfs_stress/nfs05.sh > > +++ b/testcases/network/nfs/nfs_stress/nfs05.sh > > @@ -8,8 +8,8 @@ > > # Created by: Robbie Williamson (robbiew@us.ibm.com) > > -DIR_NUM=${DIR_NUM:-"10"} > > -FILE_NUM=${FILE_NUM:-"30"} > > +DIR_NUM=${DIR_NUM:-"8"} > > +FILE_NUM=${FILE_NUM:-"28"} In the end these values are needed, when testing on systems with 64KB page size: DIR_NUM=${DIR_NUM:-"5"} FILE_NUM=${FILE_NUM:-"20"} THREAD_NUM=${THREAD_NUM:-"5"} Looking at PAGE_SIZE_LESS_THAN_256KB, CONFIG_PAGE_SIZE_LESS_THAN_256KB (option for all archs) and checking arch dependent configs I see that there can be 4KB, 8KB, 16KB, 32KB, 64KB, 256KB (each arch allows only some of them). Also filesystems evolve, thus finding safe value for *all* filesystems on different page sizes on different kernel versions might be a bit complicated. Kind regards, Petr > > THREAD_NUM=${THREAD_NUM:-"8"} > > TST_NEEDS_CMDS="make gcc" > > TST_TESTFUNC="do_test" -- Mailing list info: https://lists.linux.it/listinfo/ltp