From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2DF27C7EE23 for ; Fri, 26 May 2023 14:26:05 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id AB9D63CEC8E for ; Fri, 26 May 2023 16:26:03 +0200 (CEST) Received: from in-5.smtp.seeweb.it (in-5.smtp.seeweb.it [IPv6:2001:4b78:1:20::5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 979C23C995F for ; Fri, 26 May 2023 16:25:51 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-5.smtp.seeweb.it (Postfix) with ESMTPS id F41BB600D21 for ; Fri, 26 May 2023 16:25:50 +0200 (CEST) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D236B1FD76; Fri, 26 May 2023 14:25:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1685111149; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PUa/YoSa5krRx265/570CJieGksWRw4xXXtIHv+UlwI=; b=IgoVNHx1+iJ44uJHv4OvZbaIdwmtYOOfTZUihGWtJmcXCo4IE7Zbv877XP0zDnQV8XzNcP HurzUpLN5+QugM6bH64OO+qQzjYagaIDTRILvlWuIKptmz+vu8XSuYuPVOgIOMSL7IkXuy dkGg6BR+edII+dsjc1nwp76svHO2CBo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1685111149; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PUa/YoSa5krRx265/570CJieGksWRw4xXXtIHv+UlwI=; b=2BFER552F3l2kOHKxUf8XvuXTQAfesvJC20XD7homQCTSyvMXMBaktKnjnx5a/nwFbmKXn Q8K15SJvJwq34vAg== Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id 704CD134AB; Fri, 26 May 2023 14:25:49 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id TQuEFG3BcGRJeAAAGKfGzw (envelope-from ); Fri, 26 May 2023 14:25:49 +0000 Date: Fri, 26 May 2023 16:25:47 +0200 From: Petr Vorel To: Li Wang Message-ID: <20230526142547.GA812267@pevik> References: <20230525080934.54793-1-liwang@redhat.com> <20230525080934.54793-2-liwang@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230525080934.54793-2-liwang@redhat.com> X-Virus-Scanned: clamav-milter 1.0.1 at in-5.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH 2/2] cleanup: changing FILE_PRINTF to SAFE_FILE_PRINTF X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi Li, > SAFE_MACROS() used in cleanup do not exit the test anymore since: > commit 6440c5d0d15 (newlib: Allow SAFE_MACROS to be called from cleanup) > Signed-off-by: Li Wang > --- > testcases/kernel/device-drivers/cpufreq/cpufreq_boost.c | 4 ++-- > testcases/kernel/mem/hugetlb/hugeshmget/hugeshmget03.c | 2 +- > testcases/kernel/syscalls/fcntl/fcntl33.c | 2 +- > testcases/kernel/syscalls/readahead/readahead02.c | 2 +- > 4 files changed, 5 insertions(+), 5 deletions(-) > diff --git a/testcases/kernel/device-drivers/cpufreq/cpufreq_boost.c b/testcases/kernel/device-drivers/cpufreq/cpufreq_boost.c > index 67917b3fe..0a56519a1 100644 > --- a/testcases/kernel/device-drivers/cpufreq/cpufreq_boost.c > +++ b/testcases/kernel/device-drivers/cpufreq/cpufreq_boost.c > @@ -78,10 +78,10 @@ static void check_set_turbo(char *file, char *off) > static void cleanup(void) > { > - FILE_PRINTF(cdrv[id].file, "%d", boost_value); > + SAFE_FILE_PRINTF(cleanup, cdrv[id].file, "%d", boost_value); testcases/kernel/device-drivers/cpufreq/cpufreq_boost.c uses old API, IMHO not affected by 6440c5d0d15. Therefore we should postpone this till it's converted to the new API. The rest LGTM. Reviewed-by: Petr Vorel Kind regards, Petr -- Mailing list info: https://lists.linux.it/listinfo/ltp