* [LTP] [PATCH] shmget02: reduce the shmmax test value in compat mode
@ 2023-05-30 9:30 Li Wang
2023-05-30 12:46 ` Martin Doucha
0 siblings, 1 reply; 6+ messages in thread
From: Li Wang @ 2023-05-30 9:30 UTC (permalink / raw)
To: ltp; +Cc: Linux Kernel Functional Testing, Manfred Spraul, Arnd Bergmann
As Arnd Bergmann pointed out that SHMMAX being defined as
(ULONG_MAX - (1UL << 24)), so the kernel would likely use
a large 64-bit value, while the 32-bit user space uses a
much smaller limit.
It finally results in ENOMEM failure:
shmget02.c:95: TFAIL: shmget(1644199826, 4278190080, 1536)
expected EINVAL: ENOMEM (12)
With suggest by Manfred Spraul we could reduce the value
of '/proc/sys/kernel/shmmax' in compat mode and only test
the overflow behavior with default+1.
Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
Signed-off-by: Li Wang <liwang@redhat.com>
Cc: Naresh Kamboju <naresh.kamboju@linaro.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Manfred Spraul <manfred@colorfullife.com>
---
testcases/kernel/syscalls/ipc/shmget/shmget02.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/testcases/kernel/syscalls/ipc/shmget/shmget02.c b/testcases/kernel/syscalls/ipc/shmget/shmget02.c
index 7989ef33e..faf633ad4 100644
--- a/testcases/kernel/syscalls/ipc/shmget/shmget02.c
+++ b/testcases/kernel/syscalls/ipc/shmget/shmget02.c
@@ -56,7 +56,11 @@ static struct tcase {
{&shmkey1, SHM_SIZE, IPC_EXCL, 0, 0, ENOENT},
{&shmkey, SHM_SIZE, IPC_CREAT | IPC_EXCL, 0, 0, EEXIST},
{&shmkey1, SHMMIN - 1, IPC_CREAT | IPC_EXCL, 0, 0, EINVAL},
+#ifdef TST_ABI32
+ {&shmkey1, 8192 + 1, IPC_CREAT | IPC_EXCL, 0, 0, EINVAL},
+#else
{&shmkey1, SHMMAX + 1, IPC_CREAT | IPC_EXCL, 0, 0, EINVAL},
+#endif
{&shmkey, SHM_SIZE * 2, IPC_EXCL, 0, 0, EINVAL},
{&shmkey, SHM_SIZE, SHM_RD, 1, 0, EACCES},
{&shmkey1, SHM_SIZE, IPC_CREAT | SHM_HUGETLB, 0, 1, EPERM},
@@ -149,4 +153,10 @@ static struct tst_test test = {
.test = do_test,
.tcnt = ARRAY_SIZE(tcases),
.hugepages = {TST_NO_HUGEPAGES},
+#ifdef TST_ABI32
+ .save_restore = (const struct tst_path_val[]) {
+ {"/proc/sys/kernel/shmmax", "8192", TST_SR_TBROK},
+ {}
+ },
+#endif
};
--
2.40.1
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [LTP] [PATCH] shmget02: reduce the shmmax test value in compat mode
2023-05-30 9:30 [LTP] [PATCH] shmget02: reduce the shmmax test value in compat mode Li Wang
@ 2023-05-30 12:46 ` Martin Doucha
2023-05-30 12:56 ` Li Wang
2023-06-01 9:16 ` [LTP] [PATCH v2] " Li Wang
0 siblings, 2 replies; 6+ messages in thread
From: Martin Doucha @ 2023-05-30 12:46 UTC (permalink / raw)
To: Li Wang, ltp
Cc: Linux Kernel Functional Testing, Manfred Spraul, Arnd Bergmann
Hi,
On 30. 05. 23 11:30, Li Wang wrote:
> As Arnd Bergmann pointed out that SHMMAX being defined as
> (ULONG_MAX - (1UL << 24)), so the kernel would likely use
> a large 64-bit value, while the 32-bit user space uses a
> much smaller limit.
>
> It finally results in ENOMEM failure:
> shmget02.c:95: TFAIL: shmget(1644199826, 4278190080, 1536)
> expected EINVAL: ENOMEM (12)
>
> With suggest by Manfred Spraul we could reduce the value
> of '/proc/sys/kernel/shmmax' in compat mode and only test
> the overflow behavior with default+1.
>
> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> Signed-off-by: Li Wang <liwang@redhat.com>
> Cc: Naresh Kamboju <naresh.kamboju@linaro.org>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Manfred Spraul <manfred@colorfullife.com>
> ---
> testcases/kernel/syscalls/ipc/shmget/shmget02.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/testcases/kernel/syscalls/ipc/shmget/shmget02.c b/testcases/kernel/syscalls/ipc/shmget/shmget02.c
> index 7989ef33e..faf633ad4 100644
> --- a/testcases/kernel/syscalls/ipc/shmget/shmget02.c
> +++ b/testcases/kernel/syscalls/ipc/shmget/shmget02.c
> @@ -56,7 +56,11 @@ static struct tcase {
> {&shmkey1, SHM_SIZE, IPC_EXCL, 0, 0, ENOENT},
> {&shmkey, SHM_SIZE, IPC_CREAT | IPC_EXCL, 0, 0, EEXIST},
> {&shmkey1, SHMMIN - 1, IPC_CREAT | IPC_EXCL, 0, 0, EINVAL},
> +#ifdef TST_ABI32
> + {&shmkey1, 8192 + 1, IPC_CREAT | IPC_EXCL, 0, 0, EINVAL},
> +#else
> {&shmkey1, SHMMAX + 1, IPC_CREAT | IPC_EXCL, 0, 0, EINVAL},
> +#endif
> {&shmkey, SHM_SIZE * 2, IPC_EXCL, 0, 0, EINVAL},
> {&shmkey, SHM_SIZE, SHM_RD, 1, 0, EACCES},
> {&shmkey1, SHM_SIZE, IPC_CREAT | SHM_HUGETLB, 0, 1, EPERM},
> @@ -149,4 +153,10 @@ static struct tst_test test = {
> .test = do_test,
> .tcnt = ARRAY_SIZE(tcases),
> .hugepages = {TST_NO_HUGEPAGES},
> +#ifdef TST_ABI32
> + .save_restore = (const struct tst_path_val[]) {
> + {"/proc/sys/kernel/shmmax", "8192", TST_SR_TBROK},
> + {}
> + },
> +#endif
> };
Could this be done without the conditional compilation? For example
change the testcase to custom shmmax limit unconditionally or read the
actual kernel limit from /proc/sys/kernel/shmmax in setup().
--
Martin Doucha mdoucha@suse.cz
QA Engineer for Software Maintenance
SUSE LINUX, s.r.o.
CORSO IIa
Krizikova 148/34
186 00 Prague 8
Czech Republic
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [LTP] [PATCH] shmget02: reduce the shmmax test value in compat mode
2023-05-30 12:46 ` Martin Doucha
@ 2023-05-30 12:56 ` Li Wang
2023-06-01 9:16 ` [LTP] [PATCH v2] " Li Wang
1 sibling, 0 replies; 6+ messages in thread
From: Li Wang @ 2023-05-30 12:56 UTC (permalink / raw)
To: Martin Doucha
Cc: Linux Kernel Functional Testing, Manfred Spraul, Arnd Bergmann,
ltp
On Tue, May 30, 2023 at 8:46 PM Martin Doucha <mdoucha@suse.cz> wrote:
> Hi,
>
> On 30. 05. 23 11:30, Li Wang wrote:
> > As Arnd Bergmann pointed out that SHMMAX being defined as
> > (ULONG_MAX - (1UL << 24)), so the kernel would likely use
> > a large 64-bit value, while the 32-bit user space uses a
> > much smaller limit.
> >
> > It finally results in ENOMEM failure:
> > shmget02.c:95: TFAIL: shmget(1644199826, 4278190080, 1536)
> > expected EINVAL: ENOMEM (12)
> >
> > With suggest by Manfred Spraul we could reduce the value
> > of '/proc/sys/kernel/shmmax' in compat mode and only test
> > the overflow behavior with default+1.
> >
> > Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> > Signed-off-by: Li Wang <liwang@redhat.com>
> > Cc: Naresh Kamboju <naresh.kamboju@linaro.org>
> > Cc: Arnd Bergmann <arnd@arndb.de>
> > Cc: Manfred Spraul <manfred@colorfullife.com>
> > ---
> > testcases/kernel/syscalls/ipc/shmget/shmget02.c | 10 ++++++++++
> > 1 file changed, 10 insertions(+)
> >
> > diff --git a/testcases/kernel/syscalls/ipc/shmget/shmget02.c
> b/testcases/kernel/syscalls/ipc/shmget/shmget02.c
> > index 7989ef33e..faf633ad4 100644
> > --- a/testcases/kernel/syscalls/ipc/shmget/shmget02.c
> > +++ b/testcases/kernel/syscalls/ipc/shmget/shmget02.c
> > @@ -56,7 +56,11 @@ static struct tcase {
> > {&shmkey1, SHM_SIZE, IPC_EXCL, 0, 0, ENOENT},
> > {&shmkey, SHM_SIZE, IPC_CREAT | IPC_EXCL, 0, 0, EEXIST},
> > {&shmkey1, SHMMIN - 1, IPC_CREAT | IPC_EXCL, 0, 0, EINVAL},
> > +#ifdef TST_ABI32
> > + {&shmkey1, 8192 + 1, IPC_CREAT | IPC_EXCL, 0, 0, EINVAL},
> > +#else
> > {&shmkey1, SHMMAX + 1, IPC_CREAT | IPC_EXCL, 0, 0, EINVAL},
> > +#endif
> > {&shmkey, SHM_SIZE * 2, IPC_EXCL, 0, 0, EINVAL},
> > {&shmkey, SHM_SIZE, SHM_RD, 1, 0, EACCES},
> > {&shmkey1, SHM_SIZE, IPC_CREAT | SHM_HUGETLB, 0, 1, EPERM},
> > @@ -149,4 +153,10 @@ static struct tst_test test = {
> > .test = do_test,
> > .tcnt = ARRAY_SIZE(tcases),
> > .hugepages = {TST_NO_HUGEPAGES},
> > +#ifdef TST_ABI32
> > + .save_restore = (const struct tst_path_val[]) {
> > + {"/proc/sys/kernel/shmmax", "8192", TST_SR_TBROK},
> > + {}
> > + },
> > +#endif
> > };
>
> Could this be done without the conditional compilation? For example
> change the testcase to custom shmmax limit unconditionally or read the
> actual kernel limit from /proc/sys/kernel/shmmax in setup().
>
That could work as well, but I thought that might a bit complicated
to reassign a new value to the two-level pointer 'tc->size'.
--
Regards,
Li Wang
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 6+ messages in thread
* [LTP] [PATCH v2] shmget02: reduce the shmmax test value in compat mode
2023-05-30 12:46 ` Martin Doucha
2023-05-30 12:56 ` Li Wang
@ 2023-06-01 9:16 ` Li Wang
2023-06-01 14:51 ` Martin Doucha
1 sibling, 1 reply; 6+ messages in thread
From: Li Wang @ 2023-06-01 9:16 UTC (permalink / raw)
To: ltp; +Cc: Linux Kernel Functional Testing, Manfred Spraul, Arnd Bergmann
As Arnd Bergmann pointed out that SHMMAX being defined as
(ULONG_MAX - (1UL << 24)), so the kernel would likely use
a large 64-bit value, while the 32-bit user space uses a
much smaller limit.
It finally results in ENOMEM failure:
shmget02.c:95: TFAIL: shmget(1644199826, 4278190080, 1536)
expected EINVAL: ENOMEM (12)
With suggest by Manfred Spraul we could reduce the value
of '/proc/sys/kernel/shmmax' in compat mode and only test
the overflow behavior with default+1.
Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
Signed-off-by: Li Wang <liwang@redhat.com>
Cc: Naresh Kamboju <naresh.kamboju@linaro.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Manfred Spraul <manfred@colorfullife.com>
---
Notes:
v1 --> v2
* remove the conditional compilation for 32bit
testcases/kernel/syscalls/ipc/shmget/shmget02.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/testcases/kernel/syscalls/ipc/shmget/shmget02.c b/testcases/kernel/syscalls/ipc/shmget/shmget02.c
index 7989ef33e..e053b98d2 100644
--- a/testcases/kernel/syscalls/ipc/shmget/shmget02.c
+++ b/testcases/kernel/syscalls/ipc/shmget/shmget02.c
@@ -56,7 +56,7 @@ static struct tcase {
{&shmkey1, SHM_SIZE, IPC_EXCL, 0, 0, ENOENT},
{&shmkey, SHM_SIZE, IPC_CREAT | IPC_EXCL, 0, 0, EEXIST},
{&shmkey1, SHMMIN - 1, IPC_CREAT | IPC_EXCL, 0, 0, EINVAL},
- {&shmkey1, SHMMAX + 1, IPC_CREAT | IPC_EXCL, 0, 0, EINVAL},
+ {&shmkey1, 8192 + 1, IPC_CREAT | IPC_EXCL, 0, 0, EINVAL},
{&shmkey, SHM_SIZE * 2, IPC_EXCL, 0, 0, EINVAL},
{&shmkey, SHM_SIZE, SHM_RD, 1, 0, EACCES},
{&shmkey1, SHM_SIZE, IPC_CREAT | SHM_HUGETLB, 0, 1, EPERM},
@@ -149,4 +149,8 @@ static struct tst_test test = {
.test = do_test,
.tcnt = ARRAY_SIZE(tcases),
.hugepages = {TST_NO_HUGEPAGES},
+ .save_restore = (const struct tst_path_val[]) {
+ {"/proc/sys/kernel/shmmax", "8192", TST_SR_TBROK},
+ {}
+ },
};
--
2.40.1
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [LTP] [PATCH v2] shmget02: reduce the shmmax test value in compat mode
2023-06-01 9:16 ` [LTP] [PATCH v2] " Li Wang
@ 2023-06-01 14:51 ` Martin Doucha
2023-06-02 0:49 ` Li Wang
0 siblings, 1 reply; 6+ messages in thread
From: Martin Doucha @ 2023-06-01 14:51 UTC (permalink / raw)
To: Li Wang, ltp
Cc: Linux Kernel Functional Testing, Manfred Spraul, Arnd Bergmann
Hi,
this looks good, just one minor note at the end.
Reviewed-by: Martin Doucha <mdoucha@suse.cz>
On 01. 06. 23 11:16, Li Wang wrote:
> As Arnd Bergmann pointed out that SHMMAX being defined as
> (ULONG_MAX - (1UL << 24)), so the kernel would likely use
> a large 64-bit value, while the 32-bit user space uses a
> much smaller limit.
>
> It finally results in ENOMEM failure:
> shmget02.c:95: TFAIL: shmget(1644199826, 4278190080, 1536)
> expected EINVAL: ENOMEM (12)
>
> With suggest by Manfred Spraul we could reduce the value
> of '/proc/sys/kernel/shmmax' in compat mode and only test
> the overflow behavior with default+1.
>
> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> Signed-off-by: Li Wang <liwang@redhat.com>
> Cc: Naresh Kamboju <naresh.kamboju@linaro.org>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Manfred Spraul <manfred@colorfullife.com>
> ---
>
> Notes:
> v1 --> v2
> * remove the conditional compilation for 32bit
>
> testcases/kernel/syscalls/ipc/shmget/shmget02.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/testcases/kernel/syscalls/ipc/shmget/shmget02.c b/testcases/kernel/syscalls/ipc/shmget/shmget02.c
> index 7989ef33e..e053b98d2 100644
> --- a/testcases/kernel/syscalls/ipc/shmget/shmget02.c
> +++ b/testcases/kernel/syscalls/ipc/shmget/shmget02.c
> @@ -56,7 +56,7 @@ static struct tcase {
> {&shmkey1, SHM_SIZE, IPC_EXCL, 0, 0, ENOENT},
> {&shmkey, SHM_SIZE, IPC_CREAT | IPC_EXCL, 0, 0, EEXIST},
> {&shmkey1, SHMMIN - 1, IPC_CREAT | IPC_EXCL, 0, 0, EINVAL},
> - {&shmkey1, SHMMAX + 1, IPC_CREAT | IPC_EXCL, 0, 0, EINVAL},
> + {&shmkey1, 8192 + 1, IPC_CREAT | IPC_EXCL, 0, 0, EINVAL},
> {&shmkey, SHM_SIZE * 2, IPC_EXCL, 0, 0, EINVAL},
> {&shmkey, SHM_SIZE, SHM_RD, 1, 0, EACCES},
> {&shmkey1, SHM_SIZE, IPC_CREAT | SHM_HUGETLB, 0, 1, EPERM},
> @@ -149,4 +149,8 @@ static struct tst_test test = {
> .test = do_test,
> .tcnt = ARRAY_SIZE(tcases),
> .hugepages = {TST_NO_HUGEPAGES},
> + .save_restore = (const struct tst_path_val[]) {
> + {"/proc/sys/kernel/shmmax", "8192", TST_SR_TBROK},
> + {}
> + },
> };
/proc/sys/kernel/shmmax can be disabled by CONFIG_SYSVIPC_SYSCTL,
although that would be rare. I think the save_restore flags should be
TST_SR_TCONF_MISSING | TST_SR_TBROK_RO. This can be changed during merge.
--
Martin Doucha mdoucha@suse.cz
QA Engineer for Software Maintenance
SUSE LINUX, s.r.o.
CORSO IIa
Krizikova 148/34
186 00 Prague 8
Czech Republic
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [LTP] [PATCH v2] shmget02: reduce the shmmax test value in compat mode
2023-06-01 14:51 ` Martin Doucha
@ 2023-06-02 0:49 ` Li Wang
0 siblings, 0 replies; 6+ messages in thread
From: Li Wang @ 2023-06-02 0:49 UTC (permalink / raw)
To: Martin Doucha
Cc: Linux Kernel Functional Testing, Manfred Spraul, Arnd Bergmann,
ltp
On Thu, Jun 1, 2023 at 10:51 PM Martin Doucha <mdoucha@suse.cz> wrote:
> Hi,
> this looks good, just one minor note at the end.
>
> Reviewed-by: Martin Doucha <mdoucha@suse.cz>
>
> On 01. 06. 23 11:16, Li Wang wrote:
> > As Arnd Bergmann pointed out that SHMMAX being defined as
> > (ULONG_MAX - (1UL << 24)), so the kernel would likely use
> > a large 64-bit value, while the 32-bit user space uses a
> > much smaller limit.
> >
> > It finally results in ENOMEM failure:
> > shmget02.c:95: TFAIL: shmget(1644199826, 4278190080, 1536)
> > expected EINVAL: ENOMEM (12)
> >
> > With suggest by Manfred Spraul we could reduce the value
> > of '/proc/sys/kernel/shmmax' in compat mode and only test
> > the overflow behavior with default+1.
> >
> > Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> > Signed-off-by: Li Wang <liwang@redhat.com>
> > Cc: Naresh Kamboju <naresh.kamboju@linaro.org>
> > Cc: Arnd Bergmann <arnd@arndb.de>
> > Cc: Manfred Spraul <manfred@colorfullife.com>
> > ---
> >
> > Notes:
> > v1 --> v2
> > * remove the conditional compilation for 32bit
> >
> > testcases/kernel/syscalls/ipc/shmget/shmget02.c | 6 +++++-
> > 1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/testcases/kernel/syscalls/ipc/shmget/shmget02.c
> b/testcases/kernel/syscalls/ipc/shmget/shmget02.c
> > index 7989ef33e..e053b98d2 100644
> > --- a/testcases/kernel/syscalls/ipc/shmget/shmget02.c
> > +++ b/testcases/kernel/syscalls/ipc/shmget/shmget02.c
> > @@ -56,7 +56,7 @@ static struct tcase {
> > {&shmkey1, SHM_SIZE, IPC_EXCL, 0, 0, ENOENT},
> > {&shmkey, SHM_SIZE, IPC_CREAT | IPC_EXCL, 0, 0, EEXIST},
> > {&shmkey1, SHMMIN - 1, IPC_CREAT | IPC_EXCL, 0, 0, EINVAL},
> > - {&shmkey1, SHMMAX + 1, IPC_CREAT | IPC_EXCL, 0, 0, EINVAL},
> > + {&shmkey1, 8192 + 1, IPC_CREAT | IPC_EXCL, 0, 0, EINVAL},
> > {&shmkey, SHM_SIZE * 2, IPC_EXCL, 0, 0, EINVAL},
> > {&shmkey, SHM_SIZE, SHM_RD, 1, 0, EACCES},
> > {&shmkey1, SHM_SIZE, IPC_CREAT | SHM_HUGETLB, 0, 1, EPERM},
> > @@ -149,4 +149,8 @@ static struct tst_test test = {
> > .test = do_test,
> > .tcnt = ARRAY_SIZE(tcases),
> > .hugepages = {TST_NO_HUGEPAGES},
> > + .save_restore = (const struct tst_path_val[]) {
> > + {"/proc/sys/kernel/shmmax", "8192", TST_SR_TBROK},
> > + {}
> > + },
> > };
>
> /proc/sys/kernel/shmmax can be disabled by CONFIG_SYSVIPC_SYSCTL,
> although that would be rare. I think the save_restore flags should be
> TST_SR_TCONF_MISSING | TST_SR_TBROK_RO. This can be changed during merge.
>
Good point, patch was applied with that changes.
--
Regards,
Li Wang
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-06-02 0:49 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-30 9:30 [LTP] [PATCH] shmget02: reduce the shmmax test value in compat mode Li Wang
2023-05-30 12:46 ` Martin Doucha
2023-05-30 12:56 ` Li Wang
2023-06-01 9:16 ` [LTP] [PATCH v2] " Li Wang
2023-06-01 14:51 ` Martin Doucha
2023-06-02 0:49 ` Li Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox