Re: [LTP] [PATCH 0/2] Improve ioprio tests

Petr Vorel
2023-06-20T09:13:33Z

Hi Damien,

> The ioprio syscall tests rely on ltp internal definitions of the
> IOPRIO_XXX() macro defining priority classes and levels. With changes
> to the ioprio API to support command duration limits, these internal
> definitions are incomplete, causing test case ioprio_set03 to fail.

> Avoid this issue by having the iprio tests use the kernel header file
> definitions if that header exists. This enables additional checks in
> the header file [1] which restores the expected results with test
> ioprio_set03.

> [1] https://lore.kernel.org/linux-block/20230530061307.525644-1-dlemoal@kernel.org/

> Note: a review of this patch on the kernel block mailing list would be
> very appreciated.

I haven't found this patchset on https://lore.kernel.org/linux-block/,
did you send it there?

Kind regards,
Petr

> Damien Le Moal (2):
> ioprio: use ioprio.h kernel header if it exists
> ioprio: Use IOPRIO_PRIO_NUM to check prio range

> configure.ac | 1 +
> testcases/kernel/syscalls/ioprio/ioprio.h | 33 ++++++++++++++-----
> .../kernel/syscalls/ioprio/ioprio_set03.c | 2 +-
> 3 files changed, 26 insertions(+), 10 deletions(-)