Re: [LTP] [PATCH 0/2] Improve ioprio tests

Petr Vorel
2023-06-20T10:39:13Z

Hi all,

> On Tue, Jun 20, 2023 at 11:13:16AM +0200, Petr Vorel wrote:
> > Hi Damien,

> > > The ioprio syscall tests rely on ltp internal definitions of the
> > > IOPRIO_XXX() macro defining priority classes and levels. With changes
> > > to the ioprio API to support command duration limits, these internal
> > > definitions are incomplete, causing test case ioprio_set03 to fail.

> > > Avoid this issue by having the iprio tests use the kernel header file
> > > definitions if that header exists. This enables additional checks in
> > > the header file [1] which restores the expected results with test
> > > ioprio_set03.

> > > [1] https://lore.kernel.org/linux-block/20230530061307.525644-1-dlemoal@kernel.org/

> > > Note: a review of this patch on the kernel block mailing list would be
> > > very appreciated.

I'm sorry, I overlooked Linus' review [2], because it's not visible in
patchwork [3].

@Damien, @Linus, @Niklas FYI you need to be subscribed to post to LTP ML (unlike
vger), otherwise the message is held (and we don't check for held messages very often).
@Niklas I had to push your message due this.

> > I haven't found this patchset on https://lore.kernel.org/linux-block/,
> > did you send it there?

> Hello Petr,

> The patch series for LTP can be found here:
> https://lore.kernel.org/ltp/20230608005315.3703446-1-dlemoal@kernel.org/T/#t

Yes, it's in our LTP mailing list, thus on LTP on lore. But I expected that
linux-block ML would be in Cc (that's why Linus Walleij didn't get it in his
mailbox [4] => @Damien, do not hesitate to Cc relevant kernel (or other mailing
lists), if you expect kernel maintainers to do the review.

> I just checked LTP master, and it hasn't been applied by the
> LTP maintainers yet.

Yes, but do not worry, I'll merge it soon (likely today).

Thank to all for your time.

Kind regards,
Petr

[2] https://lore.kernel.org/ltp/CACRpkdaBinsAofvQgLZ5u8ScR0+yWPnQCf6E7CPtn598PN0eoQ@mail.gmail.com/
[3] https://patchwork.ozlabs.org/project/ltp/patch/20230605044131.798383-2-dlemoal@kernel.org/
[4] https://lore.kernel.org/ltp/CACRpkdaD3xM=Z0xTzHa+yH-wZ+LyhrSb3ZzGzkGdnboCaHw_+A@mail.gmail.com/

> Kind regards,
> Niklas