From: Murphy Zhou <jencce.kernel@gmail.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v3] safe_mount: safe_umount: print debug info about the operation
Date: Thu, 15 Jun 2023 09:24:45 +0800 [thread overview]
Message-ID: <20230615012445.4184243-1-jencce.kernel@gmail.com> (raw)
Make the source and the target to mount/umount visible. It's
good for debugging.
Signed-off-by: Murphy Zhou <jencce.kernel@gmail.com>
---
v3:
Apply suggestions from Li and Martin. Thanks very much!
lib/safe_macros.c | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/lib/safe_macros.c b/lib/safe_macros.c
index af6dd0716..26f9136af 100644
--- a/lib/safe_macros.c
+++ b/lib/safe_macros.c
@@ -898,7 +898,16 @@ int safe_mount(const char *file, const int lineno, void (*cleanup_fn)(void),
const void *data)
{
int rval = -1;
+ char mpath[PATH_MAX];
+ if (realpath(target, mpath)) {
+ tst_resm_(file, lineno, TINFO,
+ "Mounting %s to %s fstyp=%s flags=%lx",
+ source, mpath, filesystemtype, mountflags);
+ } else {
+ tst_resm_(file, lineno, TBROK | TERRNO, cleanup_fn,
+ "Cannot resolve the absolute path of %s", target);
+ }
/*
* Don't try using the kernel's NTFS driver when mounting NTFS, since
* the kernel's NTFS driver doesn't have proper write support.
@@ -948,6 +957,14 @@ int safe_umount(const char *file, const int lineno, void (*cleanup_fn)(void),
const char *target)
{
int rval;
+ char mpath[PATH_MAX];
+
+ if (realpath(target, mpath)) {
+ tst_resm_(file, lineno, TINFO, "Umounting %s", mpath);
+ } else {
+ tst_resm_(file, lineno, TBROK | TERRNO, cleanup_fn,
+ "Cannot resolve the absolute path of %s", target);
+ }
rval = tst_umount(target);
--
2.31.1
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next reply other threads:[~2023-06-15 1:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-15 1:24 Murphy Zhou [this message]
2023-06-16 2:41 ` [LTP] [PATCH v3] safe_mount: safe_umount: print debug info about the operation Li Wang
2023-06-16 2:50 ` Li Wang
2023-06-16 8:38 ` Martin Doucha
2023-06-16 9:23 ` Li Wang
2023-06-16 12:27 ` Murphy Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230615012445.4184243-1-jencce.kernel@gmail.com \
--to=jencce.kernel@gmail.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox