* [LTP] [PATCH v2] syscalls/madvise11: Ignore unpoison failure under kernel lockdown
@ 2023-06-20 16:29 Martin Doucha
2023-06-20 20:18 ` Petr Vorel
0 siblings, 1 reply; 3+ messages in thread
From: Martin Doucha @ 2023-06-20 16:29 UTC (permalink / raw)
To: Petr Vorel, ltp
When newer kernels are under lockdown, the unpoison-pfn sysfile
still appears writable to root but open() will always return EPERM.
This causes madvise11 to fail with TWARN during cleanup when run
with SecureBoot enabled.
Ignore the open(unpoison-pfn) failure due to lockdown and exit
successfully without cleanup. The test should not be skipped because
the leftover soft-offlined pages can trigger failures in later tests
and indirectly expose kernel bugs in hwpoison.
Signed-off-by: Martin Doucha <mdoucha@suse.cz>
---
Changes since v1: Print invalid return value in the error message
testcases/kernel/syscalls/madvise/madvise11.c | 17 ++++++++++++++++-
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git a/testcases/kernel/syscalls/madvise/madvise11.c b/testcases/kernel/syscalls/madvise/madvise11.c
index 2cb45d00a..4c960dd35 100644
--- a/testcases/kernel/syscalls/madvise/madvise11.c
+++ b/testcases/kernel/syscalls/madvise/madvise11.c
@@ -323,7 +323,22 @@ static int open_unpoison_pfn(void)
if (!mnt)
return -1;
- return SAFE_OPEN(debugfs_fp, O_WRONLY);
+ TEST(open(debugfs_fp, O_WRONLY));
+
+ if (TST_RET == -1 && TST_ERR == EPERM && tst_lockdown_enabled()) {
+ tst_res(TINFO,
+ "Cannot restore soft-offlined memory due to lockdown");
+ return TST_RET;
+ }
+
+ if (TST_RET == -1) {
+ tst_brk(TBROK | TTERRNO, "open(%s) failed", debugfs_fp);
+ } else if (TST_RET < 0) {
+ tst_brk(TBROK | TTERRNO, "Invalid open() return value %ld",
+ TST_RET);
+ }
+
+ return TST_RET;
}
/*
--
2.41.0
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-06-21 3:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-20 16:29 [LTP] [PATCH v2] syscalls/madvise11: Ignore unpoison failure under kernel lockdown Martin Doucha
2023-06-20 20:18 ` Petr Vorel
2023-06-21 3:00 ` Li Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox