From: Petr Vorel <pvorel@suse.cz>
To: Rick Edgecombe <rick.p.edgecombe@intel.com>
Cc: Liam.Howlett@oracle.com, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2] security/stack_clash: Add test for mmap() minding gap
Date: Wed, 21 Jun 2023 11:43:23 +0200 [thread overview]
Message-ID: <20230621094323.GB386889@pevik> (raw)
In-Reply-To: <20230531235725.389539-1-rick.p.edgecombe@intel.com>
Hi Rick,
> diff --git a/testcases/cve/stack_clash.c b/testcases/cve/stack_clash.c
...
> + /* This is not cleaned up. */
> + SAFE_MMAP((void *)lastend, size, PROT_NONE,
> + MAP_ANON|MAP_PRIVATE|MAP_FIXED_NOREPLACE, -1, 0);
MAP_FIXED_NOREPLACE is undeclared on old CentOS 7 we still support,
thus it breaks the build.
Could you please include lapi/mmap.h instead of <sys/mman.h>
(it includes <sys/mman.h>).
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2023-06-21 9:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-31 23:57 [LTP] [PATCH v2] security/stack_clash: Add test for mmap() minding gap Rick Edgecombe
2023-06-21 9:43 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230621094323.GB386889@pevik \
--to=pvorel@suse.cz \
--cc=Liam.Howlett@oracle.com \
--cc=ltp@lists.linux.it \
--cc=rick.p.edgecombe@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox