From: Petr Vorel <pvorel@suse.cz>
To: Randolph Lin <randolph@andestech.com>
Cc: minachou@andestech.com, tim609@andestech.com,
kester.tw@gmail.com, ltp@lists.linux.it,
Richard Palethorpe <rpalethorpe@suse.com>
Subject: Re: [LTP] [PATCH] syscalls/prctl04: Allow __NR_waitid in the syscall filter
Date: Tue, 27 Jun 2023 14:57:04 +0200 [thread overview]
Message-ID: <20230627125704.GA36835@pevik> (raw)
In-Reply-To: <20230627105334.2358121-1-randolph@andestech.com>
Hi Randolph,
> From: Randolph <randolph@andestech.com>
> The __NR_wait4 syscall is not available in y2038 safe 32-bit systems,
> waitid should be used instead. In the 32ABI system, the __NR_waitid
> must be allowed as well in the filter.
Acked-by: Petr Vorel <pvorel@suse.cz>
LGTM, thanks!
Kind regards,
Petr
> refer:
> https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=9b2cf9482a9397c4711c9e7f42f8d718b6306bdc
> linux: Use waitid on wait4 if __NR_wait4 is not defined
> Signed-off-by: Randolph <randolph@andestech.com>
> Signed-off-by: Dylan Jhong <dylan@andestech.com>
> ---
> testcases/kernel/syscalls/prctl/prctl04.c | 1 +
> 1 file changed, 1 insertion(+)
> diff --git a/testcases/kernel/syscalls/prctl/prctl04.c b/testcases/kernel/syscalls/prctl/prctl04.c
> index f6e1f0fea..8b135d611 100644
> --- a/testcases/kernel/syscalls/prctl/prctl04.c
> +++ b/testcases/kernel/syscalls/prctl/prctl04.c
> @@ -45,6 +45,7 @@
> static const struct sock_filter strict_filter[] = {
> BPF_STMT(BPF_LD | BPF_W | BPF_ABS, (offsetof(struct seccomp_data, nr))),
> + BPF_JUMP(BPF_JMP | BPF_JEQ, __NR_waitid, 7, 0),
> BPF_JUMP(BPF_JMP | BPF_JEQ, __NR_rt_sigprocmask, 6, 0),
> BPF_JUMP(BPF_JMP | BPF_JEQ, __NR_close, 5, 0),
> BPF_JUMP(BPF_JMP | BPF_JEQ, __NR_exit, 4, 0),
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2023-06-27 12:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-27 10:53 [LTP] [PATCH] syscalls/prctl04: Allow __NR_waitid in the syscall filter Randolph Lin
2023-06-27 12:57 ` Petr Vorel [this message]
2023-06-29 19:42 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230627125704.GA36835@pevik \
--to=pvorel@suse.cz \
--cc=kester.tw@gmail.com \
--cc=ltp@lists.linux.it \
--cc=minachou@andestech.com \
--cc=randolph@andestech.com \
--cc=rpalethorpe@suse.com \
--cc=tim609@andestech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox