From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: minachou@andestech.com, tim609@andestech.com, ltp@lists.linux.it,
x5710999x@gmail.com
Subject: Re: [LTP] [PATCH] hugeshmctl02: Skipped EFAULT tests for libc variant
Date: Tue, 27 Jun 2023 20:26:35 +0200 [thread overview]
Message-ID: <20230627182635.GA85230@pevik> (raw)
In-Reply-To: <ZJr66taHPoyDthnz@yuki>
Hi All,
Reviewed-by: Petr Vorel <pvorel@suse.cz>
LGTM.
> Hi!
> > > Okay, sounds reasonable. I agree with this.
> > BTW I also get ENOMEM on my laptop (currently 1G free space):
> > hugeshmctl02.c:119: TBROK: shmget #1: ENOMEM (12)
> > Should we handle it somehow?
> The line 119 looks suspicions, in latest git the hugeshmctl02.c does not
> even have 119 lines.
Well, it occurred with this patch (file has with it 147 lines). Previously the
version from master worked, but now it also reports ENOMEM even on master:
hugeshmctl02.c:87: TBROK: shmget #1: ENOMEM (12)
(therefore not this patch specific). Should we use .min_mem_avail? (not sure
which value).
nit: The patch subject is "hugeshmctl02: Skipped EFAULT tests for libc variant".
"Skipped" => "Skip" (we use imperative mood).
IMHO more important is the fact, that test variant was added, that's what I'd
mention in the subject. Of course, I'd keep in the commit message body that
libc variant was skipped.
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2023-06-27 18:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-15 9:39 [LTP] [PATCH] hugeshmctl02: Skipped EFAULT tests for libc variant Dylan Jhong
2023-06-26 2:36 ` Dylan Dai-Rong Jhong(鍾岱融)
2023-06-26 6:57 ` Li Wang
2023-06-26 9:14 ` Dylan Dai-Rong Jhong(鍾岱融)
2023-06-26 9:23 ` Cyril Hrubis
2023-06-27 1:26 ` Li Wang
2023-06-27 13:50 ` Petr Vorel
2023-06-27 15:06 ` Cyril Hrubis
2023-06-27 18:26 ` Petr Vorel [this message]
2023-07-06 3:13 ` Dylan Dai-Rong Jhong(鍾岱融)
2023-07-11 11:24 ` Dylan Dai-Rong Jhong(鍾岱融)
2023-07-11 22:24 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230627182635.GA85230@pevik \
--to=pvorel@suse.cz \
--cc=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=minachou@andestech.com \
--cc=tim609@andestech.com \
--cc=x5710999x@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox