From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: NeilBrown <neilb@suse.de>, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2 2/3] fsstress/global.h: Use _GNU_SOURCE
Date: Thu, 29 Jun 2023 15:32:59 +0200 [thread overview]
Message-ID: <20230629133259.GB207849@pevik> (raw)
In-Reply-To: <ZJ2EUIqpqwUn0GzC@yuki>
> Hi!
> > > Just a very minor nit, such cleanups should be in a separate patch.
> > I'm sorry, I sometimes try to blance between separating changes and too many commits.
> > I can put this to separate commit.
> I tend to be picky in separating formatting changes from actuall fixes...
I used to be, then relaxed a bit. But you're right, it makes sense.
Thus I separated this change to it's own commit.
> > > Otherwise the rest of the changes looks good:
> > Is that that this is just this patch. Please let me know if you're meant whole
> > patchset (it'd make sense, it's pretty simple).
> That was for the whole patchset, sorry for not being clear.
Thanks a lot, patchset merged (dared to add your RBT to the separated commit as
well.)
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2023-06-29 13:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-28 13:07 [LTP] [PATCH v2 0/3] Remove O_DIRECT definition Petr Vorel
2023-06-28 13:07 ` [LTP] [PATCH v2 1/3] lapi/fcntl.h: " Petr Vorel
2023-06-28 13:07 ` [LTP] [PATCH v2 2/3] fsstress/global.h: Use _GNU_SOURCE Petr Vorel
2023-06-28 13:35 ` Cyril Hrubis
2023-06-29 11:51 ` Petr Vorel
2023-06-29 13:17 ` Cyril Hrubis
2023-06-29 13:32 ` Petr Vorel [this message]
2023-06-28 13:07 ` [LTP] [PATCH v2 3/3] ltpscsi/scsimain.c: Remove O_DIRECT fallback definition Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230629133259.GB207849@pevik \
--to=pvorel@suse.cz \
--cc=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox