From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A83EDEB64DC for ; Thu, 29 Jun 2023 13:33:16 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 324CC3CE14D for ; Thu, 29 Jun 2023 15:33:14 +0200 (CEST) Received: from in-6.smtp.seeweb.it (in-6.smtp.seeweb.it [IPv6:2001:4b78:1:20::6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 553603CC305 for ; Thu, 29 Jun 2023 15:33:02 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-6.smtp.seeweb.it (Postfix) with ESMTPS id 2DA6A1400257 for ; Thu, 29 Jun 2023 15:33:01 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 788E8210E7; Thu, 29 Jun 2023 13:33:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1688045581; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HtNcbPpZ2inZM0/BA6m5EEB9YjXQMmX6vFZfBSJTyxk=; b=dLKRAukDdvIm+FOYpqC6J1cHLPOxQdv0yOU9F58xZTHlSI/qeYM1FeUhIl6uV3c4Pn+PIg o1CcRL4butCPinLNoAK1cbJZS6RUOG5V/0SqL2XLb80WevYA48GTL1/dK8pAcA8p/7voJC NGrnQW5qc/YSgsPmBjIaWCRey6JvzKg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1688045581; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HtNcbPpZ2inZM0/BA6m5EEB9YjXQMmX6vFZfBSJTyxk=; b=F0N62KygUTwk/ED6cU4vA9q2YNPuHAZeYsVFt9Emwe6/JdR7RDhILsnNUgBCuIxVV6xigb IU3WlEtyfWnteCCQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4FB93139FF; Thu, 29 Jun 2023 13:33:01 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 24ElEg2InWSiegAAMHmgww (envelope-from ); Thu, 29 Jun 2023 13:33:01 +0000 Date: Thu, 29 Jun 2023 15:32:59 +0200 From: Petr Vorel To: Cyril Hrubis Message-ID: <20230629133259.GB207849@pevik> References: <20230628130742.155724-1-pvorel@suse.cz> <20230628130742.155724-3-pvorel@suse.cz> <20230629115137.GA207849@pevik> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Virus-Scanned: clamav-milter 1.0.1 at in-6.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v2 2/3] fsstress/global.h: Use _GNU_SOURCE X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Cc: NeilBrown , ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" > Hi! > > > Just a very minor nit, such cleanups should be in a separate patch. > > I'm sorry, I sometimes try to blance between separating changes and too many commits. > > I can put this to separate commit. > I tend to be picky in separating formatting changes from actuall fixes... I used to be, then relaxed a bit. But you're right, it makes sense. Thus I separated this change to it's own commit. > > > Otherwise the rest of the changes looks good: > > Is that that this is just this patch. Please let me know if you're meant whole > > patchset (it'd make sense, it's pretty simple). > That was for the whole patchset, sorry for not being clear. Thanks a lot, patchset merged (dared to add your RBT to the separated commit as well.) Kind regards, Petr -- Mailing list info: https://lists.linux.it/listinfo/ltp