From: Petr Vorel <pvorel@suse.cz>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Jan Kara <jack@suse.cz>, ltp@lists.linux.it
Subject: Re: [LTP] [COMMITTED][PATCH 1/1] runtest: Move fanotify23 from staging to syscalls
Date: Sun, 2 Jul 2023 21:12:34 +0200 [thread overview]
Message-ID: <20230702191234.GA360317@pevik> (raw)
In-Reply-To: <CAOQ4uxjG0GrKRZE5btcbptjAaKRLj+OFMJRynPwPx4_BP4=e9g@mail.gmail.com>
Hi Amir,
> On Fri, Jun 30, 2023 at 10:38 PM Petr Vorel <pvorel@suse.cz> wrote:
> > fanotify23 is a test for FAN_MARK_EVICTABLE, prepared for v5.19-rc1.
> > We forget to move it after v5.19 being released.
> > Signed-off-by: Petr Vorel <pvorel@suse.cz>
> > ---
> > Obviously we forget to check the file after several kernel releases :(.
> > I'm sorry.
> Oh, missed your note on commit:
> [ pvorel: move test into staging ]
> If I'd known, I might have remembered to remind you ;-)
> fanotify23 and fanotify10 both added tests for
> FAN_MARK_EVICTABLE at the same time.
> But since then there were two attempts to improve the reliability
> of fanotify10:
> 48cfd7a99 syscalls/fanotify10: Make evictable marks test more reliable
> 4fefdf340 fanotify10: Make evictable marks tests more reliable
> I wonder if fanotify23's reliability did not come up so far because
> 1. It was in staging list
> 2. It has this hack:
> /* Shrinkers on other fs do not work reliably enough to
> guarantee mark eviction on drop_caches */
> .dev_fs_type = "ext2",
> I guess we will know soon ...
I wonder myself :). But I actually filled openSUSE bug [1] about fanotify23
randomly failing, when running more times (e.g. ./fanotify23 -i5). I was not
sure if it's openSUSE specific or not (I suspect the problem is generic, but 2
tested Debian systems don't suffer this), thus I first put it to the Jan's queue.
Kind regards,
Petr
[1] https://bugzilla.suse.com/1212906
> Thanks,
> Amir.
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2023-07-02 19:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-30 19:37 [LTP] [COMMITTED][PATCH 1/1] runtest: Move fanotify23 from staging to syscalls Petr Vorel
2023-07-01 14:16 ` Amir Goldstein
2023-07-02 19:12 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230702191234.GA360317@pevik \
--to=pvorel@suse.cz \
--cc=amir73il@gmail.com \
--cc=jack@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox