From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [RFC PATCH 2/3] lib/C-API: Add option -V to print LTP version
Date: Tue, 4 Jul 2023 13:50:13 +0200 [thread overview]
Message-ID: <20230704115013.GD507064@pevik> (raw)
In-Reply-To: <ZKP1afDMgcKSIESE@yuki>
Hi Cyril,
...
> > @@ -686,6 +688,10 @@ static void parse_opts(int argc, char *argv[])
> > else
> > duration = SAFE_STRTOF(optarg, 0.1, HUGE_VALF);
> > break;
> > + case 'V':
> > + fprintf(stderr, LTP_VERSION "\n");
> > + exit(0);
> > + break;
> Why don't we print that as a part of help? Do we really need to allocate
> a flag for this?
Well, people expect -V or --verbose. But because I add printing also on running
test, we could just move it to -h.
BTW I was also thinking about using getopt_long(), at least to allow --help,
I guess you don't think any value in it.
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2023-07-04 11:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-04 9:19 [LTP] [RFC PATCH 1/3] Makefile: Add C header with generated LTP version Petr Vorel
2023-07-04 9:19 ` Petr Vorel
2023-07-04 9:25 ` Petr Vorel
2023-07-13 11:58 ` Cyril Hrubis
2023-07-14 2:54 ` Li Wang
2023-07-14 4:53 ` Petr Vorel
2023-07-14 6:46 ` Cyril Hrubis
2023-07-14 9:25 ` Li Wang
2023-07-04 9:19 ` [LTP] [RFC PATCH 2/3] lib/C-API: Add option -V to print " Petr Vorel
2023-07-04 10:33 ` Cyril Hrubis
2023-07-04 11:50 ` Petr Vorel [this message]
2023-07-04 12:04 ` Cyril Hrubis
2023-07-04 12:07 ` Petr Vorel
2023-07-04 9:19 ` [LTP] [RFC PATCH 3/3] lib/C-API: Print LTP version at test start Petr Vorel
2023-07-04 9:26 ` [LTP] [RFC PATCH 1/3] Makefile: Add C header with generated LTP version Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230704115013.GD507064@pevik \
--to=pvorel@suse.cz \
--cc=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox