From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v7 3/6] Refactor mqns_03 using new LTP API
Date: Tue, 11 Jul 2023 13:09:27 +0200 [thread overview]
Message-ID: <20230711110927.GA722516@pevik> (raw)
In-Reply-To: <ZKvpXS_nPNsco63i@rei>
> Hi!
> > > I do not think that we need atomicity here, the cleanup code does not
> > > run concurently at all as the cleanup in the parent is triggered after
> > > the child did exit. I suppose that instead we need to set the mq_freed
> > > to be volatile because it's shared memory which may change at any
> > > change, so we need to tell that to the compiler.
> > That's fine, but I followed suggestions in the reviews. I think that
> > having 3 people reviewing the same patch doesn't help the development
> > process. Now I'm not sure who I should follow :-)
> It's actually the other way around, the more people look at the code the
> better, at least that way we have potential to catch more problems
> earlier. And if the reviewers disagree, let them fight for the right
> answer.
+1
Kind regards,
Petr
> I think that in this case this all can be actually simplified and we can
> get rid of the mq_freed flag as I tried to outline below.
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2023-07-11 11:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-10 12:42 [LTP] [PATCH v7 0/6] Refactor mqns testing suite Andrea Cervesato
2023-05-10 12:42 ` [LTP] [PATCH v7 1/6] Refactor mqns_01 using new LTP API Andrea Cervesato
2023-05-22 14:42 ` Cyril Hrubis
2023-05-10 12:42 ` [LTP] [PATCH v7 2/6] Refactor mqns_02 " Andrea Cervesato
2023-05-22 14:42 ` Cyril Hrubis
2023-05-10 12:42 ` [LTP] [PATCH v7 3/6] Refactor mqns_03 " Andrea Cervesato
2023-05-22 14:41 ` Cyril Hrubis
2023-07-05 13:16 ` Andrea Cervesato via ltp
2023-07-10 11:19 ` Cyril Hrubis
2023-07-11 11:09 ` Petr Vorel [this message]
2023-05-10 12:42 ` [LTP] [PATCH v7 4/6] Refactor mqns_04 " Andrea Cervesato
2023-05-22 14:54 ` Cyril Hrubis
2023-05-10 12:42 ` [LTP] [PATCH v7 5/6] Remove deprecated header files from mqns suite Andrea Cervesato
2023-05-10 12:42 ` [LTP] [PATCH v7 6/6] Remove libclone dependency " Andrea Cervesato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230711110927.GA722516@pevik \
--to=pvorel@suse.cz \
--cc=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox