From: Petr Vorel <pvorel@suse.cz>
To: "Yang Xu (Fujitsu)" <xuyang2018.jy@fujitsu.com>
Cc: "ltp@lists.linux.it" <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH v2 1/2] syscalls/geteuid01: Convert into new api
Date: Tue, 18 Jul 2023 12:02:05 +0200 [thread overview]
Message-ID: <20230718100205.GA1153123@pevik> (raw)
In-Reply-To: <934a1afb-c157-326f-21f1-776563373f13@fujitsu.com>
Hi Xu,
> Hi Petr
> > Hi Xu,
> >> + * Copyright (c) Linux Test Project, 2003-2023
> >> + * AUTHOR: William Roske, Dave Fenne
> > Very very nit: s/AUTHOR/Author/
> > Also, in the subject in both commits: s/api/API/
> > Reviewed-by: Petr Vorel <pvorel@suse.cz>
> Thanks for your review.
> I merged this patch set and modified getuid01 to origin gpl-2.0-only.
> But It seems all of uid/gid case miss to use COMPAT_TST_16_H:= 1 in
> Makefile except syscalls/setuid.
> I search the history, it seems related to a bugfix[1] when
> touch/modify/create fiel in syscall/utils.
> [1]https://github.com/linux-test-project/ltp/commit/631d16671d876524588320ee71fd23fe22750307
Good point. I send a patch which switches the logic (old tests have variable):
https://patchwork.ozlabs.org/project/ltp/patch/20230718100050.1162482-1-pvorel@suse.cz/
Kind regards,
Petr
> Best Regards
> Yang Xu
> > Kind regards,
> > Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2023-07-18 10:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-06 10:05 [LTP] [PATCH v2 1/2] syscalls/geteuid01: Convert into new api Yang Xu
2023-07-06 10:05 ` [LTP] [PATCH v2 2/2] syscalls/geteuid02: " Yang Xu
2023-07-07 9:01 ` Petr Vorel
2023-07-12 2:01 ` Yang Xu (Fujitsu)
2023-07-17 10:42 ` Yang Xu (Fujitsu)
2023-07-17 13:11 ` Petr Vorel
2023-07-10 13:46 ` [LTP] [PATCH v2 1/2] syscalls/geteuid01: " Petr Vorel
2023-07-17 14:56 ` Yang Xu (Fujitsu)
2023-07-18 10:02 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230718100205.GA1153123@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
--cc=xuyang2018.jy@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox