From: Mel Gorman <mgorman@suse.de>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: Juri Lelli <juri.lelli@redhat.com>,
Valentin Schneider <vschneid@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Jiri Bohac <jbohac@suse.cz>,
Peter Zijlstra <peterz@infradead.org>,
linux-kernel@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Ingo Molnar <mingo@redhat.com>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 2/2] sched/rt: sysctl_sched_rr_timeslice show default timeslice after reset
Date: Thu, 20 Jul 2023 11:00:02 +0100 [thread overview]
Message-ID: <20230720100002.yk7lef3fsvtohlhg@suse.de> (raw)
In-Reply-To: <20230719103743.4775-3-chrubis@suse.cz>
On Wed, Jul 19, 2023 at 12:37:43PM +0200, Cyril Hrubis wrote:
> The sched_rr_timeslice can be reset to default by writing value that is
> <= 0. However after reading from this file we always got the last value
> written, which is not useful at all.
>
> $ echo -1 > /proc/sys/kernel/sched_rr_timeslice_ms
> $ cat /proc/sys/kernel/sched_rr_timeslice_ms
> -1
>
> Fix this by setting the variable that holds the sysctl file value to the
> jiffies_to_msecs(RR_TIMESLICE) in case that <= 0 value was written.
>
> Signed-off-by: Cyril Hrubis <chrubis@suse.cz>
> CC: Jiri Bohac <jbohac@suse.cz>
Acked-by: Mel Gorman <mgorman@suse.de>
--
Mel Gorman
SUSE Labs
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2023-07-20 15:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-19 10:37 [LTP] [PATCH 0/2] Two fixes for sysctl_sched_rr_timeslice Cyril Hrubis
2023-07-19 10:37 ` [LTP] [PATCH 1/2] sched/rt: Fix sysctl_sched_rr_timeslice intial value Cyril Hrubis
2023-07-19 11:21 ` Petr Vorel
2023-07-20 9:57 ` Mel Gorman
2023-07-21 16:16 ` Petr Vorel
2023-07-19 10:37 ` [LTP] [PATCH 2/2] sched/rt: sysctl_sched_rr_timeslice show default timeslice after reset Cyril Hrubis
2023-07-20 10:00 ` Mel Gorman [this message]
2023-07-21 16:14 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230720100002.yk7lef3fsvtohlhg@suse.de \
--to=mgorman@suse.de \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=chrubis@suse.cz \
--cc=dietmar.eggemann@arm.com \
--cc=jbohac@suse.cz \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ltp@lists.linux.it \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox